Path: utzoo!utgpu!jarvis.csri.toronto.edu!rutgers!cs.utexas.edu!uunet!pilchuck!dataio!bright
From: bright@Data-IO.COM (Walter Bright)
Newsgroups: comp.lang.c
Subject: Re: strcpy
Message-ID: <2013@dataio.Data-IO.COM>
Date: 16 Jun 89 18:50:19 GMT
References: <4400001@tdpvax> <13674@haddock.ima.isc.com>
Reply-To: bright@dataio.Data-IO.COM (Walter Bright)
Organization: Data I/O Corporation; Redmond, WA
Lines: 13

In article <13674@haddock.ima.isc.com> karl@haddock.ima.isc.com (Karl Heuer) writes:
<If you want to copy overlapping strings, you should probably use
<	memmove(dest, src, strlen(src));
<since memmove() does have predictable behavior on overlap.

I get involved with helping people debug C code from time to time, and the
bug in the above code occurs frequently. I.e., the line should be:
	memmove(dest, src, strlen(src) + 1);
I'm pointing this out because it's such a common bug that it's one of the
things I routinely look for. Remember:
	static char src[] = "abc";
	sizeof(src) == 4
	strlen(src) == 3