Path: utzoo!utgpu!jarvis.csri.toronto.edu!rutgers!gatech!hubcap!ofut
From: ofut@hubcap.clemson.edu (A. Jeff Offutt)
Newsgroups: comp.software-eng
Subject: Re: code reviews
Message-ID: <5801@hubcap.clemson.edu>
Date: 19 Jun 89 20:31:00 GMT
References: <116@opel.UUCP>
Organization: Department of Computer Science, Clemson University
Lines: 41

From article <116@opel.UUCP>, by johnk@opel.UUCP (John Kennedy):
> In article <12047@bloom-beacon.MIT.EDU> tada@athena.mit.edu (Michael Zehr) writes:
> [...]
>>
>>Since part of my job here is to improve programmer productivity, i'm
>>...
>>periodic peer reviews.
>>
>>michael j zehr


> I can't help but chuckle when I see code reviews and productivity in the
> same paragraph.  It's good for the project, it's what the customer wants,
> but be assured that it's an increase in overhead and a decrease in productivity.

Now be careful that when you say "increase in overhead and a decrease in
productivity" we are all counting the same apples.  It is true that
code reviews will take time and energy away from other tasks, but it can
also save time and energy later on.  Reviewing code can significantly reduce
the amount of time spent testing the software.  In fact, some (inconclusive)
studies have indicated that code reviews are a more cost-effective way of
finding errors in software than traditional testing (other studies have
shown the opposite).  Whether or not you believe the studies completely,
it is clear that reviewing code is a very effective way to find errors
in the program.

During a code review, the programmer can check that A) the software is
somewhat related to the requirements and B) the requirements are reasonably
close to what the customer wants and what the programmers can implement.
This can significantly reduce the amount of time and money spent on
maintaining the software.

In short, saying that code reviews decrease productivity is only true over
a very *small* part of the software lifecycle, when in fact, code reviews
can decrease cost and increase quality over the *entire* lifecycle.

(Of course, code reviews are also invariably tedious, boring and painful.)
-- 
Jeff Offutt
Department of CS, Clemson University, Clemson SC  (803) 656-5882
Internet:	ofut@hubcap.clemson.edu