Path: utzoo!utgpu!jarvis.csri.toronto.edu!mailrus!csd4.csd.uwm.edu!gem.mps.ohio-state.edu!ginosko!uunet!mcsun!ukc!stl!stc!root44!miduet!news
From: reader@gec-mi-at.co.uk (Glenn Reader)
Newsgroups: comp.sources.games.bugs
Subject: conquer v4.5
Message-ID: <1989Sep7.090059.10743@gec-mi-at.co.uk>
Date: 7 Sep 89 09:00:59 GMT
Reply-To: reader@gec-mi-at.co.uk (Glenn Reader)
Organization: Marconi Instruments Ltd., St. Albans, UK
Lines: 55

I have found one bug and what looks like another, but I have not been able to
isolate this second one (not enough time).

The first causes conqrun to core dump on an arathmetic exception.
Easy to find.

In npc.c line 917 reads:-

Avg_soldiers[nation] = ntn[nation].tmil / total_sectors;

Total sectors is the number of sectors that the nation has armies in.
If the nation has been so reduced that it no longer has armies this is 0.
Result core dump.

I changed this to:-

if (total_sectors == 0) 
        Avg_soldiers[nation] = 0; 
else
        Avg_soldiers[nation] = ntn[nation].tmil / total_sectors;

I do not know the mail address of the authors so I cannot send them this
information. Could someone that knows please ensure it gets to them.

The second problem looks a lot more complex, and after a brief look i can
see why.
It manifests itself in the following way.

I attack a lot of an npc's sectors and take them.
If I then quit and then reenter the game I see a lot of error meesages.
These error messages also appear at the update.
For example.

ERROR: <edland> told to put 2188 civilians in sector 14,43 not owned - placed in capitol

On inspection 14,43 is a tokus city with about 2188 people in it.
The sector I took at 15,43 had about 50 edland people.
Result after the update instead of reducing edlands population
it went from about 55000 to over 70000.
THIS IS NOT FAIR.

Can anyone shed light on this? Are other games experiancing the same
problem.

Our game is on turn 58. It is so popular we have now run out of nations.
Hence no more revolts. I assume the number of nations is determined by
the database and I cannot just increase the number of nations and recompile.
It seems to be done with arrays. Can anyone answer this please?

I am going on Holiday tomorrow and will miss numourous updates.
I am not certain I still want to go.

I hope this is usfull and look forward to receiving any information.

Glenn