Path: utzoo!utgpu!jarvis.csri.toronto.edu!mailrus!wuarchive!brutus.cs.uiuc.edu!usc!venera.isi.edu!raveling
From: raveling@isi.edu (Paul Raveling)
Newsgroups: comp.windows.x
Subject: Re: xmh (Reply Insert Filter)
Message-ID: <9710@venera.isi.edu>
Date: 18 Sep 89 17:58:23 GMT
References: <8909162004.AA22122@expo.lcs.mit.edu> <5316@ucdavis.ucdavis.edu>
Sender: news@venera.isi.edu
Reply-To: raveling@isi.edu (Paul Raveling)
Organization: USC Information Sciences Institute
Lines: 41

In article <8909162004.AA22122@expo.lcs.mit.edu>,
converse@EXPO.LCS.MIT.EDU (Donna Converse) writes:
> 
> >   Our version of xmh (X11 version 3.1)  can't insert the old 
> > message into the reply window. It just insert the filename of 
> > the old message to the window.  
> 
> > P.S.  I'd like to hack the code if this is indeed a xmh bug.  

	Here's the bug fix that's required in msg.c:

774c774
<       argv[2] = (char*)sprintf(command, "%s %s",
---
>       sprintf(command, "%s %s",
776a777
>       argv[2] = command;

	The obvious problem is that sprintf returns an integer
	to report the number of bytes formatted, not a char pointer
	to the bytes.

> Well, would "cat" be a better default filter than "echo" ?

	Yes, when combined with the bug fix above it "works" to
	specify

		xmh*ReplyInsertFilter:  cat


	I haven't reported this to xbugs because surely it must be
	a moot point.  This must have been spotted and fixed long ago,
	and the same section of code probably has been rewritten
	anyway.  This is what should handle prefixing included lines with
	"> " or some other string, and should allow stripping header
	information out of the included message.


----------------
Paul Raveling
Raveling@isi.edu