Path: utzoo!utgpu!watmath!uunet!cs.utexas.edu!tut.cis.ohio-state.edu!XEROX.COM!Leisner.Henr
From: Leisner.Henr@XEROX.COM (Marty)
Newsgroups: gnu.utils.bug
Subject: bug in make-3.56/commands.c?
Message-ID: <891007-095006-12596@Xerox>
Date: 7 Oct 89 16:50:04 GMT
Sender: daemon@tut.cis.ohio-state.edu
Distribution: gnu
Organization: GNUs Not Usenet
Lines: 43

While reporting gnumake-3.56 to ms/dos (the dreaded system), I stumbled
across what seems to be wrong code -- I don't know if anyone else picked up
on it.

*** ../make-3.56/commands.c	Sun Sep 17 19:36:04 1989
--- commands.c	Sat Oct  7 12:40:59 1989
***************
*** 128,138 ****
        percent = savestring (p, strlen (p) - 1);
      }
    else
      {
        at = savestring (file->name, strlen (file->name));
        percent = "";
      }
- #endif
  
    DEFINE_VARIABLE ("@", 1, at);
    DEFINE_VARIABLE ("%", 1, percent);
--- 128,138 ----
        percent = savestring (p, strlen (p) - 1);
      }
    else	
+ #endif
      {
        at = savestring (file->name, strlen (file->name));
        percent = "";
      }
  
    DEFINE_VARIABLE ("@", 1, at);
    DEFINE_VARIABLE ("%", 1, percent);


at and percent are unitialized autos at DEFINE_VARIABLE without the change.

I haven't seen any bad behavior, but this looked wrong.

marty
ARPA:	leisner.henr@xerox.com
GV:  leisner.henr
NS:  leisner:wbst139:xerox
UUCP:	hplabs!arisia!leisner