Path: utzoo!bnr-vpa!bnr-fos!bigsur!bnrgate!bnr!crk56.bnr.com!janick
From: janick@crk56.bnr.com (Janick Bergeron 1617964)
Newsgroups: news.software.nntp
Subject: Bug in rn from nntp1.5
Message-ID: <44@crk56.bnr.com>
Date: 5 Oct 89 15:48:59 GMT
Sender: janick@bnr.COM
Reply-To: janick@bnr.ca
Organization: Bell-Northern Research, Ottawa, Ontario Canada
Lines: 16

I have found (and corrected) a bug in rn I got with nntp1.5.

The bug is at line #107 in the file art.c:

    if (filestat.st_mode & S_IFMT != S_IFREG)
	return DA_NORM;

should be replaced by:

    if ((filestat.st_mode & S_IFMT) != S_IFREG)
	return DA_NORM;


The operators were evaluated in the wrong order: Instead of checking
if the article was a regular file, it checked if 'others' had execute
permission.