Path: utzoo!utgpu!jarvis.csri.toronto.edu!mailrus!iuvax!ux1.cso.uiuc.edu!ux1.cso.uiuc.edu!uicsrd.csrd.uiuc.edu!kai
From: kai@uicsrd.csrd.uiuc.edu
Newsgroups: comp.windows.x
Subject: DiskSourceDestroy() bugfix
Message-ID: <5200019@uicsrd.csrd.uiuc.edu>
Date: 13 Oct 89 21:17:00 GMT
Lines: 29
Nf-ID: #N:uicsrd.csrd.uiuc.edu:5200019:000:932
Nf-From: uicsrd.csrd.uiuc.edu!kai    Oct 13 16:17:00 1989


I found and fixed a bug in the DiskSourceDestroy() routine (we have x11r3,
patch level 10).  The file wasn't closed before resources were deallocated.
It's a simple one line addition to lib/Xaw/DiskSrc.c.

This problem killed a client of mine when it ran out of file descriptors.

Patrick Wolfe    (pat@kai.com, uunet!kailand!pat)
System Manager,  Kuck and Associates, Inc.
"I'm the NRA"


===================================================================
RCS file: DiskSrc.c,v
retrieving revision 1.1
diff -c -r1.1 DiskSrc.c
*** /tmp/,RCSt1015463	Fri Oct 13 14:39:38 1989
--- DiskSrc.c	Fri Oct 13 13:20:16 1989
***************
*** 421,426 ****
--- 421,427 ----
  {
      DiskSourcePtr data;
      data = (DiskSourcePtr) src->data;
+     fclose (data->file);
      XtFree((char *) data->buffer);
      if (data->is_tempfile) {
          unlink(data->fileName);
===================================================================