Path: utzoo!utgpu!jarvis.csri.toronto.edu!mailrus!uwm.edu!cs.utexas.edu!tut.cis.ohio-state.edu!ucbvax!bloom-beacon!eru!luth!sunic!ifi!is.uu.no!ra From: ra@is.uu.no (Robert Andersson) Newsgroups: news.software.b Subject: Bnews 2.11 patch 18 lowers performance. Message-ID: <418@isncr.is.uu.no> Date: 25 Oct 89 22:57:28 GMT Organization: International Systems, Oslo, Norway Lines: 18 After I applied patch 18 I watched performance drop and the output from sar showed that rnews was running read system calls like mad. I think the problem is in the checkbatch() function in ifuncs.c. It depends on setbuf() being functional even after read's have been performed on the FILE pointer. Well, TFM for my system V.2 based system tells me setbuf() only works directly after an open. So, the unbatcher ends of doing one read system call pr. byte, since the setbuf(infp, (char *)NULL)) at the beginning of the function disables buffering completely. Bug or feature? -- Robert Andersson, International Systems, Oslo, Norway Internet: ra@is.uu.no UUCP: ...!{uunet,mcvax,ifi}!is.uu.no!ra