Path: utzoo!utgpu!jarvis.csri.toronto.edu!mailrus!cs.utexas.edu!uunet!mcsun!sunic!ifi!is.uu.no!ra From: ra@is.uu.no (Robert Andersson) Newsgroups: news.software.b Subject: Re: Bnews 2.11 patch 18 lowers performance. Message-ID: <420@isncr.is.uu.no> Date: 28 Oct 89 20:19:00 GMT References: <418@isncr.is.uu.no> Organization: International Systems, Oslo, Norway Lines: 26 In article <418@isncr.is.uu.no>, I wrote: >After I applied patch 18 I watched performance drop and the >output from sar showed that rnews was running read system calls >like mad. Since I posted this I have received two replies from: Tom Neff John Limpert Both say they have noticed the same symptoms. John even said he had posted a message similar to mine a while ago, but got no replies. patch 18 added a setbuf() call in ifuncs.c that basically makes all unbatching unbuffered, ie. one read() system call pr. character rather than one pr. BUFSIZ characters. The offending line is line 1454 in ifuncs.c *after* patch 18 has been applied. Who added this line? Why was it done? IMHO *all* setbuf calls in ifuncs.c can be removed without harm. This should make the reading buffered again, and we might not see rnews doing 300 read() system calls / second anymore. -- Robert Andersson, International Systems, Oslo, Norway Internet: ra@is.uu.no UUCP: ...!{uunet,mcvax,ifi}!is.uu.no!ra