Path: utzoo!utstat!jarvis.csri.toronto.edu!rutgers!cs.utexas.edu!uunet!alembic!csu From: csu@alembic.acs.com (Dave Mack) Newsgroups: news.software.b Subject: Re: overflow message in RN Keywords: rn Message-ID: <1989Nov19.065842.2745@alembic.acs.com> Date: 19 Nov 89 06:58:42 GMT References: <3678@devon.LNS.PA.US> Reply-To: csu@alembic.acs.com (Dave Mack) Distribution: na Organization: Alembic Computer Services, McLean VA Lines: 77 Uucp-Path: uunet!alembic!csu In article <3678@devon.LNS.PA.US> paul@devon.LNS.PA.US (Paul Sutcliffe Jr.) writes: >[ RN 4.3, patchlevel 40: ] > >When I first ported RN (several years ago) to my system, I would >occasionally get the message > > % interp buffer overflow! > >when attempting to (F)ollowup to an article. I asked the net for >a fix, and one was given. However, I no longer remember what the >fix was, and (you guessed it) now that I've recompiled RN, I'm >getting the error again. > >Will anyone who remembers the fix for this please send me e-mail? Arrrrrgh. Apply this patch. It works. Given C News message IDs, everyone will need it very soon. It provides a 2k buffer for the references line. This should prevent this problem for the next couple of months. Courtesy of Joe Buck: Index: respond.c Prereq: 4.3.1.5 *** OLDrespond.c Wed Sep 18 01:11:37 1985 --- respond.c Tue May 2 13:50:39 1989 *************** *** 1,6 **** ! /* $Header: respond.c,v 4.3.1.5 85/09/10 11:05:00 lwall Exp $ * * $Log: respond.c,v $ * Revision 4.3.1.5 85/09/10 11:05:00 lwall * Improved %m in in_char(). * --- 1,10 ---- ! /* $Header: respond.c,v 4.3.1.5+JTB 89/04/02 13:44:00 jbuck Exp $ * * $Log: respond.c,v $ + * + * Revision 4.3.1.5+JTB 89/05/02 13:44:00 jbuck + * Made a separate, quadruple-size buffer for header in followup. + * * Revision 4.3.1.5 85/09/10 11:05:00 lwall * Improved %m in in_char(). * *************** *** 354,359 **** --- 358,364 ---- followup() { bool incl_body = (*buf == 'F'); + char hbuf[4*LBUFLEN]; /* four times the old size */ artopen(art); tmpfp = fopen(headname,"w"); *************** *** 361,368 **** printf(cantcreate,headname) FLUSH; return; } ! interp(buf, (sizeof buf), getval("NEWSHEADER",NEWSHEADER)); ! fprintf(tmpfp,"%s",buf); if (incl_body && artfp != Nullfp) { #ifdef VERBOSE if (verbose) --- 366,373 ---- printf(cantcreate,headname) FLUSH; return; } ! interp(hbuf, (sizeof hbuf), getval("NEWSHEADER",NEWSHEADER)); ! fprintf(tmpfp,"%s",hbuf); if (incl_body && artfp != Nullfp) { #ifdef VERBOSE if (verbose) -- -- Joe Buck jbuck@epimass.epi.com, uunet!epimass.epi.com!jbuck