Path: utzoo!utgpu!jarvis.csri.toronto.edu!mailrus!uwm.edu!rpi!zaphod.mps.ohio-state.edu!think!mintaka!bloom-beacon!POSEUR.JPL.NASA.GOV!earle
From: earle@POSEUR.JPL.NASA.GOV (Greg Earle - Sun JPL on-site Software Support)
Newsgroups: comp.windows.x
Subject: Re: Xconsole
Message-ID: <9001161108.AA04262@poseur.jpl.nasa.gov>
Date: 16 Jan 90 11:08:51 GMT
References: <6284@ubc-cs.UUCP>
Sender: root@athena.mit.edu (Wizard A. Root)
Organization: Sun Microsystems - JPL on-site Software Support
Lines: 50

In comp.windows.x article <6284@ubc-cs.UUCP> you write:
>I seem to remember that some people had already discussed not being
>able to build the contrib client (with X11R4) xconsole. I'm wondering
>if anyone out there can send me the fix for building it, and right now,
>using gcc 1.36 on a Sun 3/60, SunOS 4.0 (lib's from X11R4), I get to:
>
>gcc -DNOSTDHDRS -fstrength-reduce -fpcc-struct-return -O   -I/nfs/leghorn/home/local/src/X/R4/mit
>  -DXAW_BC   -sun3 -c  console.c
>console.c: In function CreateConsole:
>console.c:189: `ca' undeclared (first use this function)
>console.c:189: (Each undeclared identifier is reported only once
>console.c:189: for each function it appears in.)
>console.c:189: parse error before `ddr_t'
>*** Error code 1
>make: Fatal error: Command failed for target `console.o'

[Sorry that this sounds arrogant, but sheesh ... ]
If you had looked at line 189 in console.c for more than 5 seconds, you would
have realized that one of the positional parameters is being cast to a 
caddr_t, but somehow the line got split right after the `ca' and before the
`ddr_t' (a newline snuck in somehow), which makes the compiler wonder where
these 2 strange alien variables came from.  Apply this patch:

	- Greg Earle
	  Sun Microsystems, Inc. - JPL on-site Software Support
	  earle@poseur.JPL.NASA.GOV	(Direct)
	  earle@Sun.COM			(Indirect)

Disclaimer: Don't even THINK that my opinions have anything to do with Sun's.

*** contrib/clients/xconsole/console.c.orig	Wed Dec 13 15:03:13 1989
--- contrib/clients/xconsole/console.c	Tue Jan 16 03:02:11 1990
***************
*** 185,192 ****
     Debug("creating console.");
  
    
! XtAddEventHandler(console->shell,StructureNotifyMask,False,HandleMap,(ca
! ddr_t)console);
  
     frame = XtCreateWidget("consoleFrame", formWidgetClass, console->shell, args, 0);
  
--- 185,191 ----
     Debug("creating console.");
  
    
!    XtAddEventHandler(console->shell,StructureNotifyMask,False,HandleMap,(caddr_t)console);
  
     frame = XtCreateWidget("consoleFrame", formWidgetClass, console->shell, args, 0);