Path: utzoo!attcan!uunet!ogicse!dali!uakari.primate.wisc.edu!uflorida!mephisto!udel!princeton!notecnirp!nfs From: nfs@notecnirp.Princeton.EDU (Norbert Schlenker) Newsgroups: comp.os.minix Subject: Re: fixes to unshar.c and ast.c (1.5.5) Summary: Oops Message-ID: <25060@princeton.Princeton.EDU> Date: 21 Mar 90 22:00:41 GMT References: <14467@nigel.udel.EDU> Sender: news@princeton.Princeton.EDU Reply-To: nfs@notecnirp.UUCP (Norbert Schlenker) Organization: Dept. of Computer Science, Princeton University Lines: 26 In article <14467@nigel.udel.EDU> XBR4D75G%DDATHD21.BITNET@cunyvm.cuny.edu writes: >During my upgrade process to 1.5.5, I found the following bugs in the >official version of programs "unshar.c" and "ast.c". >[unshar fix deleted] >The problem with program "ast.c" is more serious, because I only have a method >to circumvent the error but not to correct the real problem. >[ast fix deleted] Actually, this is a pretty good fix. When I posted this version of ast, I neglected to test it with the old stdio code (which I have dumped in favour of my own, and which I don't keep on disk anymore ... I have no space). So this is all my fault. The code worked for me, and I bet it works for anyone using Earl Chew's stdio package too. The old stdio's fopen() doesn't really support ANSI semantics, although it would be fairly easy to change now that 1.5 supports the O_APPEND flag in open(). I think that the stdio package should be dumped before 1.5 is finalized, and either Earl's or my package adopted as the standard. Failing such a change, I'll volunteer to fix fopen(), freopen(), and fdopen() so that they'll work correctly with 1.5 and the old stdio, IF (there's always an IF) someone will send me copies that match the 1.5.5 CRC list. Norbert