Path: utzoo!attcan!uunet!mcsun!hp4nl!ruuinf!praxis!edwin
From: edwin@praxis.cs.ruu.nl (Edwin Kremer)
Newsgroups: comp.os.minix
Subject: Re: ST-MINIX 1.5.5 "getcwd" library fix
Keywords: getcwd, libc.a, pwd, bug + patch
Message-ID: <2757@ruuinf.cs.ruu.nl>
Date: 29 Mar 90 10:11:39 GMT
References: <2746@ruuinf.cs.ruu.nl> <1842@cod.NOSC.MIL>
Sender: news@ruuinf.cs.ruu.nl
Lines: 28

In article <1842@cod.NOSC.MIL> hall@cod.NOSC.MIL (Robert R. Hall) writes:

   | I tried to apply this patch to  lib/posix/getcwd.c
   | only to have patch reject it with a core dump message
   | ...
   | Edwin Kremer would you please check you cdiff command and
   | find why it can't count correctly?

Oh boy, *am* I stupid! My cdiff counts ok, but I goofed...

This is what I did: my patch actually *was* 4 lines; a had an extra trailing
blank line that I decided *not* to add after all. So, I edited my patch,
deleted the extra line AND forgot to change the linenumbers...

I guess this is becoming the First Law of Patching: "Never patch a patch."

My apologies to all of you that had a core dump... I think Robert has
made very clear how to fix it, so there's most probably no need for a
repost (the patch is indeed very small). Anyway, if you want a repost,
let me know.


					--[ Edwin ]--
--
Edwin Kremer (SysAdm), Dept. of Computer Science, Utrecht University
Padualaan 14,   P.O. Box 80.089,  3508 TB  Utrecht,  The Netherlands
Telephone: +31-30-534104  | UUCP: ...!uunet!mcsun!hp4nl!ruuinf!edwin
Telefax  : +31-30-513791  | Email: edwin@cs.ruu.nl    [131.211.80.5]