Path: utzoo!utgpu!news-server.csri.toronto.edu!mailrus!uwm.edu!wuarchive!udel!mmdf From: archer%segin4.segin.fr@prime.com (Vincent Archer) Newsgroups: comp.os.minix Subject: Re: C SYNTAX QUESTION Message-ID: <20420@nigel.udel.EDU> Date: 28 May 90 11:21:48 GMT Sender: mmdf@udel.EDU Lines: 29 Christoph van Wuellen writes: > In the ST-1.5 distribution, kernel/stvdu.c, there is a function > with body (flush) and the EXTERN (extern) attribute. > Is this legal? It is. In K&R's C langage definition, they say that the functions have the extern storage class by default, and the global storage class is implied. So it seems perfectly legal to say "this function is external(ly accessible)!". Anyway, stvdu should be fixed, it seems more logical to define flush() as PUBLIC rather than EXTERN. > The ,,fix'' to the compiler is trivial: > if (function with body AND storage class is extern) THEN set storage class > to global. > > The question is: should I do this with the compiler, producing another > patch, or is it an error in stvdu.c? I think you'll have to produce patch #3! :-) (btw: If you gain 300 Dhrystones by compiling using C68K, I'll have a go at once! No more ACK - Sorry, ast - for me) Vincent Vincent Archer | Email:archer%segin4.segin.fr@prime.com "People that are good at finding excuses are never good at anything else"