Path: utzoo!utgpu!watserv1!watmath!att!bellcore!rutgers!cs.utexas.edu!uunet!munnari.oz.au!sirius.ucs.adelaide.edu.au!chook.ua.oz
From: cagney@chook.ua.oz (Andrew Cagney - aka Noid)
Newsgroups: comp.os.minix
Subject: Re: Incorrect CRCs for Amoeba
Message-ID: <1033@sirius.ucs.adelaide.edu.au>
Date: 16 Jun 90 05:39:49 GMT
References: <3183@leah.Albany.Edu>
Sender: news@ucs.adelaide.edu.au
Lines: 43

From article <3183@leah.Albany.Edu>, by boehme@leah.Albany.Edu (Eric M. Boehm):
> These are my results of running check_crc on the recently posted Amoeba
> distribution:
> Deleted

Actually, check_crc should have only found the following missing

amoeba/Makefile.pc              Hmm, that's odd. I can't find the darn thing
amoeba/kernel/M         Hmm, that's odd. I can't find the darn thing
amoeba/log              Hmm, that's odd. I can't find the darn thing

For the rest eg
> fs/Makefile		crc 16302 (should be 33919), count 3044 (should be 4377)
You've found a check_crc mis (?) feature :-(. Briefly,

the command `check_crc < amoeba.crc` was executed a directory tree
with the following structure:

	./amoeba/fs/Makefile	- Amoeba fs
	./fs/Makefile		- Minix fs

check_crc was looking for the file `amoeba/fs/Makefile` however the code
that does it performs the search using

	Makefile
	fs/Makefile		<- this one incorrectly gets the match
	amoeba/fs/Makefile

Hence the crc is flagged as wrong.

Workarounds are:
	1. When the crc listing is created, include redundant locality
	   information eg
	   	src/amoeba/fs/Makefile
	2. put the crc list through sed to add the extra information
	      cd /usr/src
	      sed 's/ amoeba/ src\/amoeba/' src/amoeba/amoeba.crc | check_crc

				regards
					Andrew Cagney

PS: my search code, my fault :-)
PPS: This problem is found to several programs.