Path: utzoo!utgpu!news-server.csri.toronto.edu!mailrus!cs.utexas.edu!uunet!mcsun!hp4nl!star.cs.vu.nl!ast@cs.vu.nl
From: ast@cs.vu.nl (Andy Tanenbaum)
Newsgroups: comp.os.minix
Subject: Gross bug in fs/open.c
Message-ID: <7028@star.cs.vu.nl>
Date: 27 Jun 90 22:03:22 GMT
Sender: news@cs.vu.nl
Organization: Fac. Wiskunde & Informatica, VU, Amsterdam
Lines: 27

Thanks to Martin Patzel of Germany for pointing out this truly gross bug.
That MINIX ever worked is close to a miracle.

Andy Tanenbaum (ast@cs.vu.nl)

echo x - open.cdif
sed '/^X/s///' > open.cdif << '/'
X*** open.c	Sat May  5 13:14:25 1990
X--- open.new	Wed Jun 27 23:56:54 1990
X***************
X*** 55,61 ****
X    if (fetch_name(name1, name1_length, M1) != OK) return(err_code);
X    bits = (mode & I_TYPE) | (mode & ALL_MODES & fp->fp_umask);
X    size = (unsigned int) name2;
X!   put_inode(new_node(user_path, bits, (zone_nr) addr), (off_t)size*BLOCK_SIZE);
X    return(err_code);
X  }
X  
X--- 55,61 ----
X    if (fetch_name(name1, name1_length, M1) != OK) return(err_code);
X    bits = (mode & I_TYPE) | (mode & ALL_MODES & fp->fp_umask);
X    size = (unsigned int) name2;
X!   put_inode(new_node(user_path, bits, (zone_nr) addr, (off_t)size*BLOCK_SIZE));
X    return(err_code);
X  }
X  
/