Path: utzoo!utgpu!news-server.csri.toronto.edu!mailrus!cs.utexas.edu!usc!snorkelwacker!paperboy!osf!dbrooks
From: dbrooks@osf.osf.org (David Brooks)
Newsgroups: comp.windows.x.motif
Subject: Re: XmFileSelectionBox is buggy
Keywords: XmFileSelectionBox, bug, Motif
Message-ID: <11666@paperboy.OSF.ORG>
Date: 4 Aug 90 04:25:29 GMT
References: <1202@esacs.UUCP>
Sender: news@OSF.ORG
Reply-To: dbrooks@osf.org (David Brooks)
Organization: Open Software Foundation
Lines: 42

In article <1202@esacs.UUCP> pizzi@esacs.UUCP (Riccardo Pizzi) writes:
>I decided to write a simple test program for the FileSelectionBox widget
>and discovered some nasty and (let me say it) stupid bugs....
>I don't know if these bugs are already in some official bugs list, so I
>will post them anyway.

Since you have access to source (at least 1.0.A), you have access to
an open bug list.  Please refer to it.  It will help us all.  Your
first bug appeared as PIR number 709; it got duplicated as 969 later.

[...problem with freeing "No Match" string...]

>To fix, either use strdup() at 907 or put an "if (!no_match)" before line 957.

Not quite.  Before line 959.  This one is a little subtle.

>...to the function and not an int! To fix, put search_data.value instead of
>search_data.length at line 1726 and search_data.mask at line 1739.

PIR 910.  Fixed in 1.0.3.

>
>That's all... this is the result of my first experience with this widget
>(I never used it before), but it is clear to me that this part of the Motif
>code has *never* been tested by the dev team :-(

Unfortunately, the first bug wouldn't have been found by testing on
our reference platforms which, like many machines, silently ignore
attempts to free unmalloc'ed memory...

I can make these fixes, and fixes to several memory leaks in the
FileSB, available to full support holders.

As Ron said, the 1.1 FileSB has been thoroughly revamped, and these
bugs (and the memory leaks) are no more.  There are now no bugs in
FileSB.  There are now no bugs in FileSB.  There are now no bugs in FileSB.

(what I say three times is true)

-- 
David Brooks			dbrooks@osf.org
Systems Engineering, OSF	uunet!osf.org!dbrooks