Path: utzoo!utgpu!news-server.csri.toronto.edu!cs.utexas.edu!milano!uudell!loft386!dsuvax!ghelmer
From: ghelmer@dsuvax.uucp (Guy Helmer)
Newsgroups: comp.os.minix
Subject: Re: badblocks.c
Message-ID: <1990Aug15.131050.22861@dsuvax.uucp>
Date: 15 Aug 90 13:10:50 GMT
References: <29884@bcsaic.UUCP>
Organization: Dakota State University
Lines: 49

In <29884@bcsaic.UUCP> paula@bcsaic.UUCP (Paul Allen) writes:

>Last June 19, I posted a little patch for badblocks.c.  It was
>incorrectly handling blocks whose bitmap entry was outside the first
>block of the zone bitmap.  Just recently, I got mail from Andy saying
>that he was unable to apply the patch.  Has anyone else applied the
>patch?  It was relative to 1.5.10, and the message ID was 
>26693@bcsaic.UUCP.  Have I screwed up *again* in front of the whole
>world?   :-)

I now keep sources modified from patches posted to the network on-line
on my VAX, and the diff I get for badblocks is:
------------------------------------------------------------------------------
*** /usr/users/ghelmer/minix/root/commands/badblocks.c	Mon Feb 19 16:05:10 1990
--- badblocks.c	Tue Jul 10 22:38:40 1990
***************
*** 469,475 ****
  
    block = z_num >> BIT_MAP_SHIFT;	/* which block */
    offset = z_num - (block << BIT_MAP_SHIFT);	/* offset in block */
!   words = offset / INT_BITS;	/* which word */
  
    blk_offset = (long) (2 + sp->s_imap_block);
    blk_offset *= (long) BLOCK_SIZE;
--- 469,475 ----
  
    block = z_num >> BIT_MAP_SHIFT;	/* which block */
    offset = z_num - (block << BIT_MAP_SHIFT);	/* offset in block */
!   words = z_num / INT_BITS;	/* which word */
  
    blk_offset = (long) (2 + sp->s_imap_block);
    blk_offset *= (long) BLOCK_SIZE;


-----------------------------------------------------------------------------
>Paul Allen

I'm sure my modified badblocks.c comes from your patches, Paul.
I guess I should keep a patch log file to be sure :-)

>-- 
>------------------------------------------------------------------------
>Paul L. Allen                       | pallen@atc.boeing.com
>Boeing Advanced Technology Center   | ...!uw-beaver!bcsaic!pallen
-- 
Guy Helmer
work: DSU Computing Services, Business & Education Institute    (605) 256-5315
play: MidIX System Support Services                             (605) 256-2788
dsuvax!ghelmer@cs.utexas.edu, ...!bigtex!loft386!dsuvax!ghelmer