Path: utzoo!utgpu!news-server.csri.toronto.edu!cs.utexas.edu!uunet!aplcen!haven!adm!smoke!brl.mil!moss
From: moss@brl.mil (Gary S. Moss (VLD/VMB) <moss>)
Newsgroups: comp.windows.x
Subject: xrn 6.11 bug report and patch
Keywords: xrn followup
Message-ID: <1990Sep18.134131@brl.mil>
Date: 18 Sep 90 17:41:31 GMT
Sender: news@smoke.BRL.MIL
Reply-To: moss@brl.mil
Organization: Ballistic Research Laboratory
Lines: 39

Cause:  In xrn/compose.c: followup(), the declaration for timeString is wrong,
	an obvious typo:

	char *timeString[24];		/* wrong */
	char timeString[24];		/* right */

This buffer is used to hold the date string returned from asctime().  The
result was that the string was being copied to a pointer array.

Symptom:

On a Sun 3/80 running SunOS 4.0.3, this resulted in a newline after
the year, causing the orphaned " GMT" portion of the date line to confuse
the xrn/server.c:postArticle function into prematurely terminate the header
that it sent to the NNTP server.  The end result of this was that when
doing a "followup" to an article, inews barfs with a "No title" error.

Below is an unofficial patch.
-Gary

*** compose.c.old	Tue Sep 18 13:27:38 1990
--- compose.c	Tue Sep 18 13:16:52 1990
***************
*** 1643,1649 ****
  
  #ifdef GENERATE_EXTRA_FIELDS
      long clock;
!     char *timeString[30];
  #endif
  
      if ((newsgroup->status & NG_UNPOSTABLE) == NG_UNPOSTABLE) {
--- 1643,1649 ----
  
  #ifdef GENERATE_EXTRA_FIELDS
      long clock;
!     char timeString[30];
  #endif
  
      if ((newsgroup->status & NG_UNPOSTABLE) == NG_UNPOSTABLE) {