Path: utzoo!attcan!uunet!wuarchive!zaphod.mps.ohio-state.edu!sdd.hp.com!ucsd!dog.ee.lbl.gov!pasteur!ICSI.Berkeley.EDU!stolcke From: stolcke@ICSI.Berkeley.EDU (Andreas Stolcke) Newsgroups: comp.windows.x Subject: Re: tvtwm patch 3: icon weirdness Message-ID: <28419@pasteur.Berkeley.EDU> Date: 2 Oct 90 19:30:02 GMT References: <13999@smoke.BRL.MIL> Sender: news@pasteur.Berkeley.EDU Reply-To: stolcke@ICSI.Berkeley.EDU (Andreas Stolcke) Organization: International Computer Science Institute, Berkeley, CA Lines: 39 In article <13999@smoke.BRL.MIL>, moss@brl.mil (Gary S. Moss (VLD/VMB) ) writes: |> |> Hi, |> First, let me say that tvtwm is really great! I just noticed a |> small glitch in the latest version from expo which includes patch 3, and |> am seeing some of my icons get stretched vertically. So far this behavior |> has been limited to iconified xterms, and only effects about half of them. |> They increase in height about 50% with the extra height below the label: |> I was about to post the patch below when I read your message... The icon size is recomputed incorrectly when the window managers learns of an icon title change. This small fix works for me, pending an official one from Mr. TWM himself: *** ./events.c.dist Mon Oct 1 18:53:27 1990 --- ./events.c Tue Oct 2 12:04:48 1990 *************** *** 923,929 **** Tmp_win->icon_w_height = Tmp_win->icon_height; if (Tmp_win->icon_title) ! Tmp_win->icon_w_height += Tmp_win->icon_height; Tmp_win->icon_y = Tmp_win->icon_height + Scr->IconFont.height; XResizeWindow(dpy, Tmp_win->icon_w, Tmp_win->icon_w_width, --- 923,929 ---- Tmp_win->icon_w_height = Tmp_win->icon_height; if (Tmp_win->icon_title) ! Tmp_win->icon_w_height += Scr->IconFont.height + 4; Tmp_win->icon_y = Tmp_win->icon_height + Scr->IconFont.height; XResizeWindow(dpy, Tmp_win->icon_w, Tmp_win->icon_w_width, -- Andreas Stolcke International Computer Science Institute stolcke@icsi.Berkeley.EDU 1957 Center St., Suite 600, Berkeley, CA 94704 (415) 642-4274 ext. 126