Path: utzoo!attcan!uunet!wuarchive!zaphod.mps.ohio-state.edu!rpi!uupsi!njin!khnphwzhn.njin.net!rapatel From: rapatel@khnphwzhn.njin.net ( Rakesh Patel) Newsgroups: comp.windows.x Subject: Re: WANTED: Faster X server for Sun4 w/GX Message-ID: Date: 4 Oct 90 01:17:12 GMT References: <1990Sep26.193716.17671@tandem.com> <5454@mitech.com> Organization: Rutgers Univ., New Brunswick, N.J. Lines: 38 > Given a quick and dirty hack posted only for a subset of SUN machines why > would "other kinds of machines and displays" be an issue? > >The garbage posted affects a part of the source tree that is included >in the make for several kinds of machines. It is not protected by >#ifdefs. It contains several assumptions about environments that are >not globally valid. If a "naive" user were to apply it in our >environment here, it would break about a third of our workstations, >all of them Sun-4 SunOS 4 machines. > >If the garbage made some rudimentary checks about its run-time >environment, and affect only files in the ddx/sun directory, I'd have >said nothing about it. Even so, the fact that *I* wish people >wouldn't post this kind of garbage doesn't mean that *you* shouldn't >enjoy it; no accounting for tastes. > >Bill I have to agree with Bill about the part where it contains no #ifdef's. I hadn't realized that it didn't contain them (it has been quite a while since I add that patch). When I put the patch into our distribution, I had added in the appropriate #ifdefs. Anyone using that code should definitely add the #ifdefs. I use: #if defined(sun) && defined(SUN_WINDOWS) ... #endif /* sun */ We currently don't have any machines configured with multiple frame buffers, so we have never had any problems with the code, however, I do agree with Bill that the ought to be done properly. Someone who has the patch does have such a situation and is likely to look into putting in the appropriate run-time conditionals. Rakesh Patel.