Path: utzoo!attcan!uunet!aplcen!uakari.primate.wisc.edu!sdd.hp.com!decwrl!shelby!agate!pasteur!ICSI.Berkeley.EDU!stolcke
From: stolcke@ICSI.Berkeley.EDU (Andreas Stolcke)
Newsgroups: comp.windows.x
Subject: Re: warning in compiling sunKbd.c in SunOS 4.1 make world
Keywords: X11R4 make, warning, Sun, keyboard
Message-ID: <28576@pasteur.Berkeley.EDU>
Date: 8 Oct 90 18:36:49 GMT
References: <1990Oct7.183002.11878@elroy.jpl.nasa.gov>
Sender: news@pasteur.Berkeley.EDU
Reply-To: stolcke@ICSI.Berkeley.EDU (Andreas Stolcke)
Organization: International Computer Science Institute, Berkeley, CA
Lines: 26

In article <1990Oct7.183002.11878@elroy.jpl.nasa.gov>, pjs@aristotle.JPL.NASA.gov (Peter Scott) writes:
|> I just did a make world of the X11R4.18 tree under SunOS 4.1,
|> and checked for errors and warnings.  The only ones were:
|> 
|> "sunKbd.c", line 170: warning: constant 770 is out of range of unsigned
|>  char comparison
|> "sunKbd.c", line 170: warning: result of comparison is always true

These warnings are the result of a hack in sunKbd.c used to detect Type-4
keyboards under SunOS4.0.3.  4.1 no longer requires this and the corresponding
piece of code can be taken out.  This can be done in a backward-compatible
way by replacing the

#define TYPE4KEYBOARDOVERRIDE

line with

#ifndef KIOCGKEY
#define TYPE4KEYBOARDOVERRIDE
#endif


-- 
Andreas Stolcke
International Computer Science Institute	stolcke@icsi.Berkeley.EDU
1957 Center St., Suite 600, Berkeley, CA 94704	(415) 642-4274 ext. 126