Path: utzoo!utgpu!news-server.csri.toronto.edu!cs.utexas.edu!rutgers!rochester!bukys
From: bukys@cs.rochester.edu
Newsgroups: comp.protocols.appletalk
Subject: small bugs in lwsrv
Message-ID: <1991Jan29.152952.28742@cs.rochester.edu>
Date: 29 Jan 91 15:29:52 GMT
Sender: bukys@cs.rochester.edu (Liudvikas Bukys)
Organization: University of Rochester Computer Science Department
Lines: 44

I am sending this to bug-cap@columbia.edu and comp.protocols.appletalk.
I hope that somebody out there is listening.

I found the following two errors when trying to run lwsrv for the first
time.  One is a failure to put a NULL element at the end of an execv()
argument list.  The other is a failure to pass a required argument to
wait().  In both cases, this will sometimes work, depending on the
state of your registers and stack space.  In my case it happened to
get lucky on a Sun-4/60, but failed on a Sun-3/60.

The code in question is in the src/ru-cap2.tar.Z distribution on rutgers.edu,
dated "Jan 17 18:03" (1991).

*** /tmp/,RCSt1a25074	Mon Jan 28 14:58:30 1991
--- lwsrv.c	Mon Jan 28 14:50:59 1991
***************
*** 478,483 ****
--- 478,484 ----
      }
  #endif
      childargv[i++]=tname;
+     childargv[i++]= (char*)NULL;
      if( aufsdb )
  	chown(tname,requid,reqgid);
  
***************
*** 504,510 ****
  #ifdef NeXT
        wait(waitstatus);
  #else
!       wait(); /* wait for the lpr to do its thing */
  #endif
        break;
      }
--- 505,511 ----
  #ifdef NeXT
        wait(waitstatus);
  #else
!       wait(0); /* wait for the lpr to do its thing */
  #endif
        break;
      }

That's all, folks.