Path: utzoo!utgpu!news-server.csri.toronto.edu!cs.utexas.edu!swrinde!zaphod.mps.ohio-state.edu!think.com!paperboy!hsdndev!cmcl2!kramden.acf.nyu.edu!brnstnd
From: brnstnd@kramden.acf.nyu.edu (Dan Bernstein)
Newsgroups: comp.unix.programmer
Subject: Re: winsize struct
Message-ID: <17803:Feb1319:45:0991@kramden.acf.nyu.edu>
Date: 13 Feb 91 19:45:09 GMT
References: <1991Feb11.192013.6587@mccc.edu> <1991Feb12.211450.28938@athena.mit.edu> <1991Feb13.032238.11640@athena.mit.edu>
Organization: IR
Lines: 20

In article <1991Feb13.032238.11640@athena.mit.edu> scs@adam.mit.edu writes:
  [ use #ifdef SIGWINCH for winsize; use #ifdef S_IFLNK for symlinks ]
> Don't put the
> code for catching SIGTSTP inside #ifdef JOBCONTROL; put it inside
> #ifdef SIGTSTP.  Settable line disciplines?  TIOCSETD.
> Etc.

I have to disagree. There may be occasional cases where the macros
provided by the system exactly match the features you want to use, but
you'll never lose anything by sticking to #ifdef JOBCONTROL and putting

	#ifdef SIGTSTP
	#define JOBCONTROL
	#endif

inside a .h file. This way someone can (1) figure out what you really
meant while reading the code; (2) change the definitions with as little
work as possible in case you messed up.

---Dan