Path: utzoo!utgpu!watserv1!watmath!att!linac!uwm.edu!caen!sdd.hp.com!spool.mu.edu!uunet!mcsun!tuvie!nestroy!mah
From: mah@nestroy.wu-wien.ac.at (Michael Haberler)
Newsgroups: news.software.nntp
Subject: Buglet in nntpxmit.c (and fix)
Message-ID: <1991Feb22.101644.23631@nestroy.wu-wien.ac.at>
Date: 22 Feb 91 10:16:44 GMT
Reply-To: mah@nestroy.wu-wien.ac.at (Michael Haberler)
Organization: Wirtschaftsuniversitaet Wien
Lines: 47


Our downstream feed got stuck recently with coredumps from nntpxmit, so
I had a look at it with the debugger. It died on trying to
syslog() the following message-id:

19910215.072910.cotrssm%navhost@sea04vm.navsea.navy.mil

which has meaning to sprintf() but no arguments to substitute. The
following patch takes care of this (nntp.1.5.8, it's still in 1.5.11, with
an 'if (skip == FALSE)' before the syslog()).

-michael

*** nntpxmit.c.ORIG	Fri Feb 22 10:40:32 1991
--- nntpxmit.c	Fri Feb 22 10:42:53 1991
***************
*** 1079,1085 ****
  	case L_WARNING:	importance = LOG_WARNING;	break;
  	default:	importance = LOG_DEBUG;		break;
  	}
! 	syslog(importance, error);
  #endif	SYSLOG
  }
  
--- 1079,1095 ----
  	case L_WARNING:	importance = LOG_WARNING;	break;
  	default:	importance = LOG_DEBUG;		break;
  	}
! #ifdef STALL_ON_WEIRD_MESSAGE_IDS
! 	syslog(importance, error); 
! 	/* this drops core with a message id like the
! 	 * following:
! 	 * <19910215.072910.cotrssm%navhost@sea04vm.navsea.navy.mil>
! 	 *                         ^^ here!!
! 	 * michael haberler mah@nestroy.wu-wien.ac.at
! 	 */
! #else
! 	syslog(importance, "%s", error);
! #endif
  #endif	SYSLOG
  }
  
-- 
Michael Haberler	mah@nestroy.wu-wien.ac.at, mah@awiwuw11.bitnet
University of Economics and Business Administration 
Augasse 2-6,  A-1090 Vienna, Austria		
Tel: +43 (222) 313-36 x4796 (9-18 CET) 	Fax 347-555


Brought to you by Super Global Mega Corp .com