Path: utzoo!utgpu!news-server.csri.toronto.edu!rpi!zaphod.mps.ohio-state.edu!sdd.hp.com!spool.mu.edu!uunet!mcsun!hp4nl!utrcu1!mi.eltn.utwente.nl!klamer From: klamer@mi.eltn.utwente.nl (Klamer Schutte) Newsgroups: comp.os.minix Subject: rm(1) dumps core + fix Summary: check your arguments! Message-ID: Date: 8 Apr 91 12:42:07 GMT Article-I.D.: mi.klamer.671114527 Sender: news@utrcu1.UUCP Organization: University of Twente, BSC-El Lines: 52 The program rm dumps core on atari-st when called as: rm -rf This because there was no test for the possibility of no arguments. Fix is below Klamer PS You should patchthis against /usr/src/commands/rm.c (I have to learn working with rcs ;-) echo x - rm.c.cdif sed '/^X/s///' > rm.c.cdif << '/' X*** 1.1 1991/04/08 11:50:34 X--- 1.2 1991/04/08 11:56:06 X*************** X*** 19,25 **** X if (argc < 2) usage(); X *++argv; X --argc; X! while (**argv == '-') { X opt = *argv; X while (*++opt != '\0') switch (*opt) { X case 'f': fflag++; break; X--- 19,25 ---- X if (argc < 2) usage(); X *++argv; X --argc; X! while ((argc >= 1) && (**argv == '-')) { X opt = *argv; X while (*++opt != '\0') switch (*opt) { X case 'f': fflag++; break; / echo x - rm.uue sed '/^X/s///' > rm.uue << '/' Xtable X !"#$%&'()*+,-./0123456789:;<=>? X@ABCDEFGHIJKLMNOPQRSTUVWXYZ[\]^_ Xbegin 644 rm.c.cdif.Z XM'YV-*@*"B.$B1H(8.7+$> &#!D,< V/HJ %#QPP:"EIH'.A"QL&$"QL^C#C1z XMA@X8-A0$7,FRI0J5 A&RD%$#!$L%('*"2&,&!(HP09.&31F? :_: =&C!X@3+4X@W2,Ux XMP1LX=-C:5*L51(*Q9<^BH+KB;MX0;D]P@2$7Q)P[:>B,08/6\-RZ";:."3/Gw XM[ DS)W0D,&.&#=.J.Q*(D5,FS)JH&EL,S#&S9NP64G/R].F5J%&D2IDZA9K;v XM9E6^Q;L&_:H@;$[ 9GW^7 ["A]L82$V80*M"+=O$<5-,?[S:QS<^>WH(E&FFEGH*8::ZY%!6D7t X s Xend / -- Klamer Schutte Faculty of electrical engineering -- University of Twente, The Netherlands klamer@mi.eltn.utwente.nl {backbone}!mcsun!mi.eltn.utwente.nl!klamer