Path: utzoo!utgpu!news-server.csri.toronto.edu!rpi!zaphod.mps.ohio-state.edu!wuarchive!uunet!comp.vuw.ac.nz!toru.isor.vuw.ac.nz!jonathan
From: jonathan@toru.isor.vuw.ac.nz (Jonathan Stone)
Newsgroups: comp.bugs.4bsd
Subject: Reno /usr/include/signal.h bad for ANSI compilers
Keywords: ANSI, C, signal.h, pid_t
Message-ID: <1991May09.070655.10621@comp.vuw.ac.nz>
Date: 9 May 91 07:06:55 GMT
Sender: news@comp.vuw.ac.nz (News Admin)
Organization: ISOR, Victoria University of Wellington, NZ
Lines: 31
Nntp-Posting-Host: toru.isor.vuw.ac.nz

Symptom::
   Builds of the X window system fail on 4.3-Reno when using gcc,
   with many error messages about a parse error in line 209 of
   /usr/include/signal.h.

Bug::
    /usr/include/signal.h references the type pid_t when __STDC__ is
    defined, but does not define this type anywhere, or #include a
    definition of it.

Fix::
   Make /usr/include/signal.h (really /sys/sys/signal.h) include
   the definition of pid_t from <sys/types.h> when  __STDC__ is
   defined (and perhaps when it's not, depending on taste).
   The following patch does this, albeit in questionable style.

   This may or may not be appropriate when compiling the kernel.

Subject: Reno /usr/include/signal.h bad for ANSI compilers
*** /usr/src/sys/sys/signal.h.dist	Sun Jul 29 06:55:41 1990
--- /usr/src/sys/sys/signal.h	Thu May  9 15:58:04 1991
***************
*** 206,211 ****
--- 206,212 ----
  #endif /* KERNEL */
  
  #if __STDC__ || c_plusplus
+ #include <sys/types.h>
  int kill(pid_t, int);
  int sigaction(int, const struct sigaction *, struct sigaction *);
  int sigprocmask(int, const sigset_t *, sigset_t *);