Path: utzoo!utgpu!news-server.csri.toronto.edu!rpi!think.com!snorkelwacker.mit.edu!bloom-beacon!eru!hagbard!sunic!isgate!krafla!adamd
From: adamd@rhi.hi.is (Adam David)
Newsgroups: comp.os.minix
Subject: Re: Bug in ST-kernel 1.5.10.4
Message-ID: <3252@krafla.rhi.hi.is>
Date: 15 Jun 91 12:41:26 GMT
References: <56110@nigel.ee.udel.edu>
Organization: University of Iceland
Lines: 31

In <56110@nigel.ee.udel.edu> breure%ITIHP1.TNO.NL@pucc.princeton.edu (Frank Breure) writes:

>It is the function "set_name", which was in stdmp.c and now is in dmp.c,
>the new function has one more parameter but is still called with the old
>number of parameters in "system.c".

Thanks for pointing this out, Frank. This must be the reason that CTRL-ALT-F1
no longer finds the process name.

>proto.h:
>_PROTOTYPE( void set_name, (int source_nr, int proc_nr, char *ptr));
                                 ^^^^^^^^^
Can anyone tell us what this extra parameter is for. The change is not very
well documented as to what its purpose is.

>system.c:
>set_name(m_ptr->PROC1, (char *)sp);     /* save command string for F1 display */
>set_name(proc_nr, (char *) 0);  /* disable command printing for F1 */

Obviously a suitable value for source_nr needs to be added to the left of the
parameter list in these function calls. It seems to me that simply duplicating
the first parameter here will fix this kernel bug quite adequately and display
the names correctly. I haven't had a chance to check it yet though.

set_name is called elsewhere with different values for source_nr and proc_nr
so it is not an acceptable solution to remove source_nr from the function
definition.

--
Adam David.
(adamd@rhi.hi.is)