Relay-Version: version B 2.10 5/3/83; site utzoo.UUCP
Posting-Version: version B 2.10 Apollo; site apollo.UUCP
Path: utzoo!linus!decvax!wivax!apollo!rees
From: rees@apollo.UUCP (Jim Rees)
Newsgroups: net.news.b,net.bugs
Subject: Re: bugs in news 2.10.1, advice to authors
Message-ID: <222@apollo.UUCP>
Date: Mon, 9-Jan-84 09:38:38 EST
Article-I.D.: apollo.222
Posted: Mon Jan  9 09:38:38 1984
Date-Received: Tue, 10-Jan-84 00:36:55 EST
References: <1610@utcsstat.UUCP>
Organization: Apollo Computer, Chelmsford, Mass.
Lines: 24


    There is a further minor bug in inews.c.
    At the start of localize(), the line

	actfp = fopen(ACTIVE, "r+");

    appears, and actfp is never tested to see if fopen succeeded.

Yes, I fixed that one here a while ago.  There isn't any really
sane thing to do at that point, so I made it an xerror().

In the same routine, there are two places where the function
will return without fcloseing ACTIVE, either.  Try submitting an
article with the following "Newsgroups:" line to rnews:

Newsgroups: general,a,b,c,d,e,f,g,h,i,j,k,l,m,n,o,p,q,r,s,t,u,v,w,x,y,z

Each of those invalid groups will leave a hanging FILE pointer, and
you will run out after just a few of them.  Granted this is a
pathological case, but I don't think it is wise to leave these
things open after they are needed.

The fix is to put a "fclose(actfp)" before each of the two "return FALSE"
statements.