Relay-Version: version B 2.10 5/3/83; site utzoo.UUCP
Posting-Version: version B 2.10.1 6/24/83; site astrovax.UUCP
Path: utzoo!watmath!clyde!burl!ulysses!allegra!princeton!astrovax!wls
From: wls@astrovax.UUCP (William L. Sebok)
Newsgroups: net.bugs.4bsd,net.unix-wizards
Subject: DTR not enabled on dh driver when soft carrier flag set.
Message-ID: <231@astrovax.UUCP>
Date: Mon, 5-Mar-84 16:49:33 EST
Article-I.D.: astrovax.231
Posted: Mon Mar  5 16:49:33 1984
Date-Received: Tue, 6-Mar-84 03:26:59 EST
Organization: Princeton Univ. Astrophysics
Lines: 41

This bug may have been noted before but I am not sure when.  Also please note
the other bug in the handling of the soft carrier flag in the dh driver
reported by Lou Salkind (i.e. the line hangs up when Carrier is dropped even
though the soft carrier flag is set).

Index:	/sys/vaxuba/dh.c 4.2BSD

Description:
	If the soft carrier flag for a dh line is set (dhsoftCAR), data terminal
	ready (DTR) will never be set on open.  Thus, terminals (or modems)
	which require DTR will not work.
Repeat-By:
	Connect a terminal or modem which requires DTR to a line with modem
	control which has dhsoftCAR  set.  The device will not operate.
Fix:

*** dh.c.ORIG	Fri Jul 29 10:33:35 1983
--- dh.c	Thu Jan 26 02:21:49 1984
***************
*** 633,640
  	dm = unit >> 4;
  	tp = &dh11[unit];
  	unit &= 0xf;
! 	if (dm >= NDH || (ui = dminfo[dm]) == 0 || ui->ui_alive == 0 ||
! 	    (dhsoftCAR[dm]&(1<<unit))) {
  		tp->t_state |= TS_CARR_ON;
  		return;
  	}

--- 633,639 -----
  	dm = unit >> 4;
  	tp = &dh11[unit];
  	unit &= 0xf;
! 	if (dm >= NDH || (ui = dminfo[dm]) == 0 || ui->ui_alive == 0) {
  		tp->t_state |= TS_CARR_ON;
  		return;
  	}
***************
-- 
Bill Sebok			Princeton University, Astrophysics
{allegra,akgua,burl,cbosgd,decvax,ihnp4,kpno,princeton,vax135}!astrovax!wls