Relay-Version: version B 2.10 5/3/83; site utzoo.UUCP
Posting-Version: version B 2.10.1 6/24/83; site ucbvax.UUCP
Path: utzoo!watmath!clyde!burl!ulysses!harpo!decvax!ucbvax!mckusick
From: mckusick@ucbvax.UUCP (Kirk Mckusick)
Newsgroups: net.bugs.4bsd
Subject: bug in dump
Message-ID: <470@ucbvax.UUCP>
Date: Sat, 24-Mar-84 16:58:20 EST
Article-I.D.: ucbvax.470
Posted: Sat Mar 24 16:58:20 1984
Date-Received: Sun, 25-Mar-84 19:05:07 EST
Organization: U.C. Berkeley
Lines: 37

From: dlw@berkeley (David L Wasley)
Subject: bug in dump
Index:	/usr/src/etc/dump	4.2	Fix

Description:
	The problem is that restore needs the full inode bitmap
	for the filesystem. Dump, as distributed, truncates the
	map to the smallest size possible (the highest inode of
	interest). This causes restore to FAIL in some cases.

Repeat-by:
	newfs /dev/rra0h ra81
	dump 0 /dev/rra0h
	...(add stuff to the filesystem)...
	dump 3 /dev/rra0h

	Now try to restore it.

Fix:
	Below is a diff of dumptraverse.c that will fix the bug.
	The line numbers may not match yours. The routine is
	``bitmap()''.
------
diff  dumptraverse.c.old  dumptraverse.c
------
210,218c211
< 	n = -1;
< 	for (i = 0; i < msiz; i++)
< 		if(map[i])
< 			n = i;
< 	if (n < 0)
< 		return;
< 	n++;
<
< 	spcl.c_count = howmany(n * sizeof(map[0]), TP_BSIZE);
---
> 	spcl.c_count = howmany(msiz * sizeof(map[0]), TP_BSIZE);