Relay-Version: version B 2.10 5/3/83; site utzoo.UUCP
Posting-Version: version B 2.10.1 6/24/83; site cepu.UUCP
Path: utzoo!watmath!clyde!akgua!sdcsvax!bmcg!cepu!scw
From: scw@cepu.UUCP
Newsgroups: net.bugs.uucp,net.bugs.v7,net.bugs.2bsd
Subject: uuxqt bug (time outs on lock file), v7 + others
Message-ID: <265@cepu.UUCP>
Date: Thu, 24-May-84 17:16:40 EDT
Article-I.D.: cepu.265
Posted: Thu May 24 17:16:40 1984
Date-Received: Thu, 31-May-84 19:39:59 EDT
Organization: VA Wadsworth Med. Center; LA CA
Lines: 51

There is a bug in uuxqt.c involving very long execute times (with many executes)
    SYSTEMS Affected:
	v7, v7m, Ultrix-11(??), 2.8BSD, 2.9BSD(??); Anyone with v7 derived
	uucp (?probably);
    Symptoms:
	Several copies if uuxtq run simultaniously.
    Cause:
	uuxtq doen't update the lock (LCK.XQT) between processes.
    Repeat by:
	Exec several files (so that total execute time is longer than
	the X_LOCKTIME (uucp.h). This can happen if you get several
	days worth of news into your system when it's very busy.
    Fix:
	Make the following changes to uuxqt.c to update X_LOCK just before
	every search/execute cycle.

--- uuxqt.c.B	Wed Jan 18 13:13:04 1984
*** uuxqt.c	Thu May 24 13:18:25 1984
***************
--- 50,55 -----
  	char *getprm();
  	int uid, ret;
  	int stcico = 0;
  	Debug = 0;

*** 50,56
  	int uid, ret;
+ 	long now,timep[2];		/* to update lock file*/
  	int stcico = 0;

***************
--- 81,86 -----
  	while (gtxfile(xfile) > 0) {
  		DEBUG(4, "xfile - %s\n", xfile);
  
  		xfp = fopen(xfile, "r");
  		ASSERT(xfp != NULL, "CAN'T OPEN %s", xfile);
  
*** 83,91
  	while (gtxfile(xfile) > 0) {
  		DEBUG(4, "xfile - %s\n", xfile);
  
+ 		time(&now);			/* get time */
+ 		timep[0]=timep[1]=now;		/* set up table */
+ 		utime(X_LOCK,timep);		/* and fix lock time up*/
  		xfp = fopen(xfile, "r");
  		ASSERT(xfp != NULL, "CAN'T OPEN %s", xfile);
-- 
Stephen C. Woods (VA Wadsworth Med Ctr./UCLA Dept. of Neurology)
uucp:	{ {ihnp4, uiucdcs}!bradley, hao, trwrb, sdcsvax!bmcg}!cepu!scw
ARPA: cepu!scw@ucla-locus       location: N 34 06'37" W 118 25'43"