Relay-Version: version B 2.10 5/3/83; site utzoo.UUCP
Posting-Version: version B 2.10.1 Fluke 1/4/84; site fluke.UUCP
Path: utzoo!linus!decvax!ittvax!dcdwest!sdcsvax!sdcrdcf!hplabs!tektronix!uw-beaver!ssc-vax!fluke!joe
From: joe@fluke.UUCP
Newsgroups: net.news.b
Subject: Re: assorted 2.10.1 bug fixes and changes
Message-ID: <1584@vax4.fluke.UUCP>
Date: Wed, 16-May-84 14:58:52 EDT
Article-I.D.: vax4.1584
Posted: Wed May 16 14:58:52 1984
Date-Received: Tue, 22-May-84 01:05:50 EDT
References: <1889@utcsstat.UUCP> <1f49d991.1147@apollo.uucp>
Organization: John Fluke Mfg. Co., Everett, WA
Lines: 22

Geoff's (and Jim's) fix both have the undesirable side effect that if
you try to do anything "interesting" at the "Last article" prompt,
readnews will probably dump core.  The reason is that many of the
options in the big switch in command() try to close(fp).  If you are at
the "Last article" prompt, fp == NULL and fclose immediately gets an
illegal reference and dumps.  The fix is to enclose all occurrences of
the two lines
	fclose(fp);
	fp = NULL;
in command() with
	if (fp != NULL) {
		<as above>
	}
Note that there are already several cases which have taken into account
that fp might be NULL.  I think there are six or seven unprotected
fclose's.

Also, if you unsubscribe to the last newsgroup in the active file,
readnews doesn't print the Last article prompt.  I haven't looked into
this one very closely yet.  Maybe I'll install Jim's version of readr
first.

/Joe