Relay-Version: version B 2.10 5/3/83; site utzoo.UUCP
Posting-Version: version B 2.10 5/3/83; site umcp-cs.UUCP
Path: utzoo!linus!philabs!cmcl2!seismo!rlgvax!cvl!umcp-cs!chris
From: chris@umcp-cs.UUCP
Newsgroups: net.emacs
Subject: Re:  CIT500 driver for EMACS
Message-ID: <7715@umcp-cs.UUCP>
Date: Mon, 2-Jul-84 03:26:27 EDT
Article-I.D.: umcp-cs.7715
Posted: Mon Jul  2 03:26:27 1984
Date-Received: Tue, 3-Jul-84 03:42:28 EDT
References: <262@rna.UUCP>
Organization: Univ. of Maryland, Computer Science Dept.
Lines: 26

Just got around to looking at rna!dan's CIT500 terminal driver.  I noticed
one odd thing in the code.  In TrmCIT500(), there is the following:

	if (tgetent (tbuf, term) <= 0) {
		tt.t_length = CIT_LI = tgetnum("li");
		tt.t_width = CIT_CO = tgetnum("co")
		.
		.
		.

Now, I don't know about your tgetent, but ours (4.1BSD) returns 1 if
the tgetent succeeded.  So it seems to me that the code should say

	if (tgetent (tbuf, term) > 0) {
		.
		.
		.

Other than that, it looks reasonable.  By the way, for Emacs #264
you'd want to change all the padding calls to use fltofixp and
friends.  (For mine, you'd use the `pad' routine in display.c with
`long' values in terms of microseconds, but then you don't have mine.)
-- 
In-Real-Life: Chris Torek, Univ of MD Comp Sci (301) 454-7690
UUCP:	{seismo,allegra,brl-bmd}!umcp-cs!chris
CSNet:	chris@umcp-cs		ARPA:	chris@maryland