Relay-Version: version B 2.10 5/3/83; site utzoo.UUCP
Path: utzoo!watmath!clyde!burl!ulysses!mhuxl!ihnp4!drutx!houxe!hogpc!houti!ariel!vax135!cornell!uw-beaver!tektronix!hplabs!hpda!fortune!amd!decwrl!decvax!cca!ima!ism780b!jim
From: jim@ism780b.UUCP
Newsgroups: net.lang.c
Subject: Re: Re: Preprocessor Trickery - (nf)
Message-ID: <19@ism780b.UUCP>
Date: Thu, 2-Aug-84 00:18:18 EDT
Article-I.D.: ism780b.19
Posted: Thu Aug  2 00:18:18 1984
Date-Received: Sun, 22-Jul-84 03:09:07 EDT
Lines: 50

#R:elsie:-101400:ism780b:25500010:000:1888
ism780b!jim    Jul 17 21:58:00 1984

>
>         >Try typing this to see what happens:
>         >       cc -E -
>         >       #define Ident(xxx) xxx
>         >       #define concat(a,b) Ident(a)b
>         >       __LINE__
>         >       concat(__LINE__,__LINE__)
>
> "concat(__LINE__,__LINE__)" gives "__LINE____LINE__"
> "concat(__LINE__, __LINE__)" gives, e.g.,  "3 3"

Not with a Reiser cpp (this is just one of the hundreds of bugs;
I too rolled my own).

>For that matter:        "concat(this,that)" results in "thisthat"
>                        "concat(this, that)" results in "this that"

Easy to explain: the arguments to a macro consist of the text between
parens and commas (not nested within parens), including any white space.
Thus, you concatenated "this" with " that".  The problem is that there
is no formal documentation of cpp.

> Defining "concat(a, b)" instead of "concat(a,b)" doesn't, however, seem to
> make a difference.

Of course, since "a" and "b" are just tokens to be replaced in the replacement
text.

> It *is* interesting behavior.

Not very.

> And also reinforces my
> general feelings that:  (a) relying on the preprocessor to do too much for you
> is foolish, and (b) being very clever is a really fun way to screw up those
that follow you (or yourself when you have to go back to the miserable thing
two years later and have forgotten how terribly clever you were), especially
when you follow the customary C commenting conventions.

Definitely true given that it is undocumented, although understandable when
the only alternative is m4.  When defining a macro which can be tucked away
in a common include file with plenty of comments can allow you to write
far more readable and modifiable code elsewhere, then it may not be so
foolish.  However, if it is just used to support another favorite hack,
then the cause is lost anyway.

-- Jim Balter, INTERACTIVE Systems (ima!jim)