Relay-Version: version B 2.10 5/3/83; site utzoo.UUCP
Posting-Version: version B 2.10.1 6/24/83 (MC840302); site turing.UUCP
Path: utzoo!linus!philabs!cmcl2!seismo!mcvax!turing!aeb
From: aeb@turing.UUCP
Newsgroups: net.sources.bugs
Subject: Re: help command
Message-ID: <222@turing.UUCP>
Date: Tue, 13-Nov-84 10:36:12 EST
Article-I.D.: turing.222
Posted: Tue Nov 13 10:36:12 1984
Date-Received: Thu, 15-Nov-84 01:18:10 EST
References: <372@udenva.UUCP>
Organization: CWI, Amsterdam
Lines: 24
Apparently-To: rnews@mcvax.LOCAL

This is a nice little program; unfortunately it dumped core on me the
very first time I tried it.
Patch (around the call of send_man):
	if(item_ptr->down == NULLPTR)	/* must be manual */ {
		send_man(item_ptr);
		item_ptr = item_ptr->up;
	}
	item_count = send_list(item_ptr->down);

and don't let send_man return any value. (While looking at the code in
send_man() you might note some other bizarre things, like the double
call to wait, and the return after execlp failed.)

The problem was that after a call to send_man item_count had the wrong
value, so that any legal answer would give a core dump.

(I cannot give a diff listing since I ran the source through indent
and threw out all full line comments without information that made
the program so difficult to read. Well chosen identifiers are a better
documentation than comments like
/*......... here the variables are declared ...........................*/
and the likes.)
-- 
      Andries Brouwer -- CWI, Amsterdam -- {philabs,decvax}!mcvax!aeb