Relay-Version: version B 2.10 5/3/83; site utzoo.UUCP
Posting-Version: version B 2.10.1 6/24/83; site umcp-cs.UUCP
Path: utzoo!watmath!clyde!burl!ulysses!allegra!mit-eddie!think!harvard!seismo!umcp-cs!chris
From: chris@umcp-cs.UUCP (Chris Torek)
Newsgroups: net.sources.bugs
Subject: Re: DHU-11 driver for 4.2BSD
Message-ID: <1470@umcp-cs.UUCP>
Date: Tue, 3-Sep-85 21:16:25 EDT
Article-I.D.: umcp-cs.1470
Posted: Tue Sep  3 21:16:25 1985
Date-Received: Thu, 5-Sep-85 07:11:38 EDT
References: <1060@cs.reading.UUCP>
Organization: U of Maryland, Computer Science Dept., College Park, MD
Lines: 21
Keywords: DHU-11 4.2BSD

Two quick things I noticed:

If you want this to coexist with a dh, change

	int cbase[MAXNUBA];

to

	static int cbase[MAXNUBA];

Also, you have propagated a bug from the dh driver; dhuioctl
should check

		if (cmd == TIOCSETP || cmd == TIOCSETN || cmd == TIOCLSET ||
		    cmd == TIOCLBIS || cmd == TIOCLBIC)

instead of just the first two, before calling dhuparam.
-- 
In-Real-Life: Chris Torek, Univ of MD Comp Sci Dept (+1 301 454 4251)
UUCP:	seismo!umcp-cs!chris
CSNet:	chris@umcp-cs		ARPA:	chris@maryland