Relay-Version: version B 2.10 5/3/83; site utzoo.UUCP
Posting-Version: version B 2.10.2 9/18/84 SMI; site sun.uucp
Path: utzoo!watmath!clyde!bonnie!akgua!whuxlm!harpo!decvax!decwrl!sun!guy
From: guy@sun.uucp (Guy Harris)
Newsgroups: net.unix
Subject: Re: rcs blows up on suns
Message-ID: <2772@sun.uucp>
Date: Sun, 8-Sep-85 18:28:33 EDT
Article-I.D.: sun.2772
Posted: Sun Sep  8 18:28:33 1985
Date-Received: Tue, 10-Sep-85 03:32:55 EDT
References: <830@panda.UUCP> <1075@sdcsvax.UUCP> <961@sdcsla.UUCP> <967@sdcsla.UUCP>
Distribution: net
Organization: Sun Microsystems, Inc.
Lines: 36

> As I stated in my original reply, dereferencing zero is always
> a bad idea, even though it `works' (returns 0) on Vaxen.   So,
> it isn't Sun's fault per se, and I don't think RCS is really
> a supported product of Sun Microsystems... (anyone from Sun
> care to comment on this?).

RCS is not a supported product of Sun Microsystems.  SMI doesn't distribute
RCS on any of its standard distribution tapes.

Here's a fix to "rcs.c" to keep it from dropping core (this fix was
originally discovered on another 68000-family machine which prohibits
dereferencing null pointers):

*** rcs.c.broken	Sun Sep  8 15:25:18 1985
--- rcs.c	Sun Sep  8 15:26:51 1985
***************
*** 982,988
          dummy.nextlock=next=Locks;
          trail = &dummy;
          while (next!=nil) {
!                numr = strcmp(num, next->delta->num);
                 if ((whor=strcmp(who,next->login))==0 &&
                    (num==nil || numr==0))
                          break; /* found a lock */

--- 982,989 -----
          dummy.nextlock=next=Locks;
          trail = &dummy;
          while (next!=nil) {
!                if(num!=nil)
!                        numr = strcmp(num, next->delta->num);
                 if ((whor=strcmp(who,next->login))==0 &&
                    (num==nil || numr==0))
                          break; /* found a lock */

	Guy Harris