Relay-Version: version B 2.10 5/3/83; site utzoo.UUCP
Posting-Version: version B 2.10.1 6/24/83; site umcp-cs.UUCP
Path: utzoo!linus!philabs!cmcl2!seismo!umcp-cs!chris
From: chris@umcp-cs.UUCP (Chris Torek)
Newsgroups: net.unix-wizards
Subject: Re: minor bug in dump, can cause system to hang.
Message-ID: <1742@umcp-cs.UUCP>
Date: Wed, 2-Oct-85 16:32:04 EDT
Article-I.D.: umcp-cs.1742
Posted: Wed Oct  2 16:32:04 1985
Date-Received: Wed, 9-Oct-85 06:45:23 EDT
References: <1763@brl-tgr.ARPA> <14694@onfcanim.UUCP>
Organization: U of Maryland, Computer Science Dept., College Park, MD
Lines: 35

> But why fix dump when the problem is almost certainly in the disk driver?

Exactly.  Your fix is correct, but possibly incomplete.  Here is the
other change from Berkeley for the ecc code:

*** 911,916
  #endif
                bp->b_flags &= ~B_BAD;
!               mbp->mba_bcr = -(bp->b_bcount - (int)ptob(npf));
!               if (MASKREG(mbp->mba_bcr) == 0)
                        return (0);
                break;
--- 927,931 -----
  #endif
                bp->b_flags &= ~B_BAD;
!               if ((int)ptob(npf) >= bp->b_bcount)
                        return (0);
                mbp->mba_bcr = -(bp->b_bcount - (int)ptob(npf));
***************
*** 914,917
                if (MASKREG(mbp->mba_bcr) == 0)
                        return (0);
                break;
        }

--- 929,933 -----
                if ((int)ptob(npf) >= bp->b_bcount)
                        return (0);
+               mbp->mba_bcr = -(bp->b_bcount - (int)ptob(npf));
                break;
        }
-- 
In-Real-Life: Chris Torek, Univ of MD Comp Sci Dept (+1 301 454 4251)
UUCP:	seismo!umcp-cs!chris
CSNet:	chris@umcp-cs		ARPA:	chris@mimsy.umd.edu