Relay-Version: version B 2.10 5/3/83; site utzoo.UUCP
Posting-Version: version B 2.10.2 9/18/84; site watmath.UUCP
Path: utzoo!watmath!rjwhite
From: rjwhite@watmath.UUCP (RJ White)
Newsgroups: net.bugs.uucp
Subject: bug in uucico causes spooled files to get removed
Message-ID: <1804@watmath.UUCP>
Date: Mon, 24-Mar-86 18:21:23 EST
Article-I.D.: watmath.1804
Posted: Mon Mar 24 18:21:23 1986
Date-Received: Tue, 25-Mar-86 04:16:56 EST
Distribution: net
Organization: University of Waterloo [MFCF]
Lines: 54

Last night we lost alot of stuff queued for ihnp4 because it looks like
their filesystem was full and couldn't create any temporary files.
The code checks for this and if sending the file bombs because of this,
then it isn't supposed to remove the file that it couldn't send.
The problem is, the wrong byte is checked in the status message sent back.
The following is a diff so that it will now FAIL instead of trying to
continue since there is no point in continuing if the disk is full.
The file is cntrl.c


*** cntrl.c	Mon Mar 24 17:55:04 1986
--- new_cntrl.c	Mon Mar 24 17:57:54 1986
***************
*** 318,325
  			ASSERT(role == MASTER, "WRONG ROLE", "", role);
  			fclose(fp);
  			fp = NULL;
! 			if (msg[1] != '4')
! 				unlinkdf(W_DFILE);
  			goto top;
  		}
  

--- 318,328 -----
  			ASSERT(role == MASTER, "WRONG ROLE", "", role);
  			fclose(fp);
  			fp = NULL;
! 			if (msg[2] == '4') {	/* from EM_NOTMP , msg="SN4" */
! 				(*Turnoff)();
! 				return( FAIL );
! 			}
! 			unlinkdf(W_DFILE);
  			goto top;
  		}
  
***************
*** 390,396
  			WMESG(SNDFILE, EM_NOTMP);
  			logent("CAN'T OPEN", "DENIED");
  			unlinkdf(Dfile);
! 			goto top;
  		}
  
  		WMESG(SNDFILE, YES);

--- 393,400 -----
  			WMESG(SNDFILE, EM_NOTMP);
  			logent("CAN'T OPEN", "DENIED");
  			unlinkdf(Dfile);
! 			(*Turnoff)();
! 			return( FAIL );
  		}
  
  		WMESG(SNDFILE, YES);