Relay-Version: version B 2.10 5/3/83; site utzoo.UUCP
Path: utzoo!mnetor!seismo!rutgers!clyde!cbatt!cbosgd!gatech!spaf
From: spaf@gatech.EDU (Gene Spafford)
Newsgroups: net.bugs.uucp
Subject: Re: 4.3BSD uucp bugs?
Message-ID: <5493@gatech.EDU>
Date: Sat, 1-Nov-86 13:04:44 EST
Article-I.D.: gatech.5493
Posted: Sat Nov  1 13:04:44 1986
Date-Received: Mon, 3-Nov-86 22:18:13 EST
References: <8766@sun.uucp>
Reply-To: spaf@gatech.UUCP (Gene Spafford)
Distribution: net
Organization: Software Engineering Research Center (SERC), Georgia Tech
Lines: 41
Summary: Fix for 4.3 uucp bug

In article <8766@sun.uucp> shannon@sun.uucp (Bill Shannon) writes:
>Recently two sites that we talk to upgraded to the 4.3BSD uucp
>(one running on 4.3, the other running it on some other system).
>Immediately after they upgraded, we began having problems talking
>to them.  Our conversations would usually end in the middle with
>"expected 'S', got FAIL" or something similar.  One of the sites
>has since converted back to the 4.2 uucp and the problems have
>disappeared.  Has anyone else had similar problems?  Does anyone
>know of any bugs in the 4.3 uucp?


Yes indeedy.  The following change to pk1.c should fix the problem your
neighbors are having.  Symptoms are that the bug manifests itself when
noise causes a packet to get mangled and you get an EXPECT/FAIL error.
Somebody broke the code between the Beta release version and the final
4.3 release.

*** pk1.c.orig	Thu Sep 18 22:12:54 1986
--- pk1.c	Wed Oct  1 22:25:13 1986
***************
*** 196,202 ****
  		return;
  	}
  	if (k && pksizes[k] == pk->p_rsize) {
! 		pk->p_rpr = (h->cntl >> 3) & MOD8;
  		pksack(pk);
  		bp = pk->p_ipool;
  		if (bp == NULL) {
--- 196,202 ----
  		return;
  	}
  	if (k && pksizes[k] == pk->p_rsize) {
! 		pk->p_rpr = h->cntl & MOD8;   /* This is the correct one. EHS */
  		pksack(pk);
  		bp = pk->p_ipool;
  		if (bp == NULL) {
-- 
Gene Spafford
Software Engineering Research Center (SERC), Georgia Tech, Atlanta GA 30332
CSNet:	Spaf @ GATech		ARPA:	Spaf@ics.GATECH.EDU
uucp:	...!{akgua,decvax,hplabs,ihnp4,linus,seismo,ulysses}!gatech!spaf