Relay-Version: version B 2.10 5/3/83; site utzoo.UUCP
Posting-Version: version B 2.10.2 9/18/84; site watdragon.UUCP
Path: utzoo!watmath!watnot!watdragon!jvkelley
From: jvkelley@watdragon.UUCP (Jeff Kelley)
Newsgroups: net.micro.amiga
Subject: Re: Possible bug in vt100
Message-ID: <1637@watdragon.UUCP>
Date: Sun, 19-Oct-86 14:29:42 EDT
Article-I.D.: watdrago.1637
Posted: Sun Oct 19 14:29:42 1986
Date-Received: Tue, 21-Oct-86 21:31:33 EDT
References: <305@pttesac.UUCP> <257@hao.UUCP> <308@pttesac.UUCP> <2358@gitpyr.gatech.EDU> <2002@videovax.UUCP>
Reply-To: jvkelley@watdragon.UUCP (Jeff Kelley)
Organization: U of Waterloo, Ontario
Lines: 28
Summary: 


[ Don't you hate massive includes of previous postings?]

The line in window.c " if (class=RAWKEY) " is incorrect.  This was pointed
out way back in V1.0, and I don't know why it has never been fixed by Dave.

To see why it's incorrect, consider the following.  RAWKEY is a constant, so the
result of the condition will be constant.  If it's false, (RAWKEY is 0)
then you can get rid of the body of the 'if' and save some memory.  If
it's true, then get rid of the 'if' and just do "class = RAWKEY;" and go
into the body of the 'if'.  Incidentally, this is not an uncommon mistake
made by beginning C programmers.  (I know!)

So please, Dave, change it to "if (class==RAWKEY) " in your source.

Here's another enhancement to vt100.  The two functions cursoron() and
cursoroff() are identical.  With each new version I delete cursoroff(),
change the name of cursoron() to cursorflip() and change all the
appropriate calls, definitions, etc.  I suspect that the compiler 
wouldn't recognize the two identical functions and do this for me.

	Thanks, Dave for a really useful program.

	Jeff Kelley                      {...!ihnp4!watmath!watdragon!jvkelley}
	Department of Computer Science
	University of Waterloo
	Waterloo, Ontario
	N2L 3G1