Relay-Version: version B 2.10 5/3/83; site utzoo.UUCP
Path: utzoo!utcs!bnr-vpa!bruce
From: bruce@bnr-vpa.UUCP
Newsgroups: news.admin,news.software.b
Subject: Bug in checkgroups script in 2.11 for USG systems
Message-ID: <111@bnr-vpa.UUCP>
Date: Fri, 14-Nov-86 09:15:22 EST
Article-I.D.: bnr-vpa.111
Posted: Fri Nov 14 09:15:22 1986
Date-Received: Fri, 14-Nov-86 20:23:14 EST
Organization: Bell-Northern Research, Ottawa, Ontario
Lines: 59
Keywords: 14 character file names
Xref: utcs news.admin:3 news.software.b:8

-------------------------

	There is a bug in the 2.11 checkgroups script which applies
to all systems which have 14 character file names.  Two temporary
files potentially have the same first 14 characters when prepended
by a 4 or 5 character process id:
	/tmp/12345active.mod.all (where 12345 is the process id)
	/tmp/12345active.mod
This messes up the checking of moderated newsgroups.
	The fix is easy: change $$active.mod.all to $$act.mod.all

A context diff for checkgroups.sh (the source for checkgroups) is
given below.

regards,
			Bruce Townsend (bnr-vpa!bruce)
			Bell-Northern Research,
			Ottawa, Ontario.
Phone:	(613) 726-3008
Mail path: {utzoo, utcs}!bnr-vpa!bruce

*** checkgroups.old	Fri Nov 14 09:05:27 1986
--- checkgroups.sh	Fri Nov 14 09:07:33 1986
***************
*** 33,39
  comm -23 /tmp/$$active /tmp/$$newsgroups >/tmp/$$remove
  
  egrep "${group}" LIBDIR/active | sed -n "/m\$/s/ .*//p" |
! 	sort > /tmp/$$active.mod.all
  egrep "${group}" LIBDIR/newsgroups |
  sed -n "/Moderated/s/[ 	][ 	]*.*//p" | sort > /tmp/$$newsg.mod
  

--- 33,39 -----
  comm -23 /tmp/$$active /tmp/$$newsgroups >/tmp/$$remove
  
  egrep "${group}" LIBDIR/active | sed -n "/m\$/s/ .*//p" |
! 	sort > /tmp/$$act.mod.all
  egrep "${group}" LIBDIR/newsgroups |
  sed -n "/Moderated/s/[ 	][ 	]*.*//p" | sort > /tmp/$$newsg.mod
  
***************
*** 41,47
  comm -23 /tmp/$$missing /tmp/$$newsg.mod >/tmp/$$add.unmod
  cat /tmp/$$add.mod /tmp/$$add.unmod >>/tmp/$$add
  
! comm -23 /tmp/$$active.mod.all /tmp/$$remove >/tmp/$$active.mod
  comm -13 /tmp/$$newsg.mod /tmp/$$active.mod >/tmp/$$ismod
  comm -23 /tmp/$$newsg.mod /tmp/$$active.mod >/tmp/$$notmod.all
  comm -23 /tmp/$$notmod.all /tmp/$$add >/tmp/$$notmod

--- 41,47 -----
  comm -23 /tmp/$$missing /tmp/$$newsg.mod >/tmp/$$add.unmod
  cat /tmp/$$add.mod /tmp/$$add.unmod >>/tmp/$$add
  
! comm -23 /tmp/$$act.mod.all /tmp/$$remove >/tmp/$$active.mod
  comm -13 /tmp/$$newsg.mod /tmp/$$active.mod >/tmp/$$ismod
  comm -23 /tmp/$$newsg.mod /tmp/$$active.mod >/tmp/$$notmod.all
  comm -23 /tmp/$$notmod.all /tmp/$$add >/tmp/$$notmod