Relay-Version: version B 2.10 5/3/83; site utzoo.UUCP Path: utzoo!utgpu!water!watnot!watmath!clyde!rutgers!dayton!viper!john From: john@viper.UUCP Newsgroups: comp.emacs,comp.sys.atari.st Subject: Re: uEmacs38b Fixes for ATARI ST Message-ID: <791@viper.UUCP> Date: Tue, 7-Apr-87 23:38:17 EST Article-I.D.: viper.791 Posted: Tue Apr 7 23:38:17 1987 Date-Received: Sat, 11-Apr-87 04:17:59 EST References: <48200001@tub.UUCP> <273@xios.XIOS.UUCP> Reply-To: john@viper.UUCP (John Stanley) Organization: DynaSoft Systems Lines: 49 Xref: utgpu comp.emacs:758 comp.sys.atari.st:2592 In article <273@xios.XIOS.UUCP> greg@xios.UUCP (Greg Franks) writes: > >line. Megamax insists on calling a short a char. Once you have done >this step, edit search.c and isearch.c and change the occurances of > > short int > >to > > int > >Megamax WILL BOMB on lines like "int int c". > Why make a "fix" that could actualy -Cause- portability problems? If you're going to make any changes along the lines you mentioned, it should be to change the short int statements to short which will be consistant with the new "short" portability macro you defined and will avoid changing how the system runs on other systems. Just kicking out the "short" part of the define may make the code compile correctly on -YOUR- machine, but it totaly ignores the original intent of those variables and could cause problems or larger than necessary programs on other systems or other compilers... Not real- -REAL- likely for this one case, but the substitution you suggest is, in general, a poor way to fix the poblem when a more portable method is just as easy and lends itself to other situations as well... > >I'll be sending the diffs to lawrence@duncan once I get my modem set up >(again). > Before you send in your changes, Please double check your changes with a little imagination and make sure they're not likely to cause problems for people using other compilers or other machines... --- John Stanley (john@viper.UUCP) Software Consultant - DynaSoft Systems UUCP: ...{amdahl,ihnp4,rutgers}!{meccts,dayton}!viper!john