Relay-Version: version B 2.10 5/3/83; site utzoo.UUCP
Path: utzoo!utgpu!water!watnot!watmath!clyde!rutgers!seismo!mcvax!ukc!dcl-cs!stephen
From: stephen@dcl-cs.UUCP
Newsgroups: news.software.b,uk.net
Subject: 2.11: recurrent (idiotic restriction + bug)
Message-ID: <241@dcl-csvax.comp.lancs.ac.uk>
Date: Tue, 24-Feb-87 23:11:59 EST
Article-I.D.: dcl-csva.241
Posted: Tue Feb 24 23:11:59 1987
Date-Received: Fri, 27-Feb-87 21:07:30 EST
Expires: Tue, 31-Mar-87 18:00:00 EST
Reply-To: stephen@comp.lancs.ac.uk (Stephen J. Muir)
Distribution: world
Organization: Department of Computing at Lancaster University, UK.
Lines: 286
Keywords: MYDOMAIN, ME
Xref: utgpu news.software.b:318 junk:4818

I have asked Rick Seismo to do something about these and, each time a patch was
issued, nothing had been done and I mailed him again asking him to fix the
following two problems, so I've decided to make public what I am asking in the
hope that I will be able to get some support.

Firstly, the stupid restriction in the use of MYDOMAIN, for which I include
the patches, relative to 2.11 patch #4.  I keep asking Rick Adams to
incorporate these in his next patch but he never seems to.  The problem is
that, if your UUCP name is not a subdomain of your domain name, the news
software is unusable.  For example, we are called "dcl-cs" and our domain name
is "comp.lancs.ac.uk".  This also affects several other sites, e.g.:

	hwcs -> cs.hw.ac.uk
	strath-cs -> cs.strath.ac.uk
	icdoc -> doc.ic.ac.uk

This restriction is silly, especially as we chose our domain name before we
got UUCP.  In this case, if our lowest subdomain already exists as a UUCP site,
we either have to change our domain name or run up against this problem.  With
these patches, the UUCP name is used in the "Path" header, but the domain name
is used elsewhere.  These patches simply mean that MYDOMAIN is set to the
complete domain name so, in seismo's case, they would set it to
"seismo.css.gov" rather than ".css.gov".

Here is the second problem:

I have been using the MYDOMAIN patches since installing 2.11 (I had no choice).
I have edited them each time I applied one of the patches so that they still
work.  Before applying patch #1, everything worked fine.  After applying
patch #1, our news system started sending every news article to itself.  After
applying patch #2, and subsequent patches, it only sends locally posted news to
itself.  In addition, it wouldn't recognise "ME" in the sys file as documented.
I believe that this is not caused by my patches since the news system could
simple say:

	if ( ! strcmp (name, "ME"))
		goto nosend;

To Rick Adams:
	I would appreciate it if you could incorporate my changes in your next
patch and fix the ME and sending news to oneself syndrome.

To everyone else:
	If you see anything wrong with what I'm doing, I would appreciate
hearing from you.
----------------------------------- Cut Here ----------------------------------
#!/bin/sh
echo 'Start of pack.out, part 01 of 01:'
echo 'x - src.control.c.diff'
sed 's/^X//' > src.control.c.diff << '/'
X*** control.c.orig	Tue Jan 13 03:16:17 1987
X--- control.c	Tue Jan 13 03:25:55 1987
X***************
X*** 210,216
X  	(void) sprintf(header.title, "sendme%s %s", list, FULLSYSNAME);
X  	(void) strcpy(header.ctlmsg, header.title);
X  	getident(&header);
X! 	(void) sprintf(header.from, "%s@%s%s", "usenet", FULLSYSNAME, MYDOMAIN);
X  	(void) strcpy(header.path, NEWSUSR);
X  	header.subdate[0] = header.expdate[0] = '\0';
X  	dates(&header);
X
X--- 210,216 -----
X  	(void) sprintf(header.title, "sendme%s %s", list, FULLSYSNAME);
X  	(void) strcpy(header.ctlmsg, header.title);
X  	getident(&header);
X! 	(void) sprintf(header.from, "%s@%s", "usenet", MYDOMAIN);
X  	(void) strcpy(header.path, NEWSUSR);
X  	header.subdate[0] = header.expdate[0] = '\0';
X  	dates(&header);
X***************
X*** 935,942
X  		(void) time(&now);
X  		fprintf(fp, "Date: %s\n", arpadate(&now));
X  #ifdef MMDF
X! 		fprintf(fp, "From: The News System <usenet@%s%s>\n",
X! 				FULLSYSNAME, MYDOMAIN);
X  #endif /* MMDF */
X  		fprintf(fp, "To: %s\n", to);
X  		fprintf(fp, "Subject: %s\n", subject);
X
X--- 935,942 -----
X  		(void) time(&now);
X  		fprintf(fp, "Date: %s\n", arpadate(&now));
X  #ifdef MMDF
X! 		fprintf(fp, "From: The News System <usenet@%s>\n",
X! 				MYDOMAIN);
X  #endif /* MMDF */
X  		fprintf(fp, "To: %s\n", to);
X  		fprintf(fp, "Subject: %s\n", subject);
X***************
X*** 942,949
X  		fprintf(fp, "Subject: %s\n", subject);
X  #ifdef HIDDENNET
X  		if (strcmp(LOCALSYSNAME, FULLSYSNAME))
X! 			fprintf(fp, "Responding-System: %s.%s%s\n\n",
X! 				LOCALSYSNAME, FULLSYSNAME, MYDOMAIN);
X  		else
X  #endif /* !HIDDENNET */
X  			fprintf(fp, "Responding-System: %s%s\n\n",
X
X--- 942,949 -----
X  		fprintf(fp, "Subject: %s\n", subject);
X  #ifdef HIDDENNET
X  		if (strcmp(LOCALSYSNAME, FULLSYSNAME))
X! 			fprintf(fp, "Responding-System: %s.%s\n\n",
X! 				LOCALSYSNAME, MYDOMAIN);
X  		else
X  #endif /* !HIDDENNET */
X  			fprintf(fp, "Responding-System: %s\n\n",
X***************
X*** 946,953
X  				LOCALSYSNAME, FULLSYSNAME, MYDOMAIN);
X  		else
X  #endif /* !HIDDENNET */
X! 			fprintf(fp, "Responding-System: %s%s\n\n",
X! 				FULLSYSNAME, MYDOMAIN);
X  	}
X  	return fp;
X  }
X
X--- 946,953 -----
X  				LOCALSYSNAME, MYDOMAIN);
X  		else
X  #endif /* !HIDDENNET */
X! 			fprintf(fp, "Responding-System: %s\n\n",
X! 				MYDOMAIN);
X  	}
X  	return fp;
X  }
/
echo 'x - src.header.c.diff'
sed 's/^X//' > src.header.c.diff << '/'
X*** header.c.orig	Sat Dec 20 19:32:58 1986
X--- header.c	Sat Dec 20 19:49:49 1986
X***************
X*** 314,320
X  	tp = index(host, '@');
X  	if (tp != NULL)
X  		*tp = 0;
X! 	(void) sprintf(hp->from, "%s@%s%s", user, host, MYDOMAIN);
X  
X  	skin(pathbuf, fullname, hp->path);	/* remove RFC822-style comments */
X  	if (fullname[0] != '\0') {
X
X--- 314,320 -----
X  	tp = index(host, '@');
X  	if (tp != NULL)
X  		*tp = 0;
X! 	(void) sprintf(hp->from, "%s@%s", user, MYDOMAIN);
X  
X  	skin(pathbuf, fullname, hp->path);	/* remove RFC822-style comments */
X  	if (fullname[0] != '\0') {
/
echo 'x - src.ifuncs.c.diff'
sed 's/^X//' > src.ifuncs.c.diff << '/'
X*** ifuncs.c.orig	Wed Feb 25 02:42:21 1987
X--- ifuncs.c	Wed Feb 25 02:45:37 1987
X***************
X*** 783,789
X  	unlock();
X  #ifdef HIDDENNET
X  	if (strcmp(LOCALSYSNAME, FULLSYSNAME))
X! 		(void) sprintf(hp->ident, "<%ld@%s.%s%s>", seqn, LOCALSYSNAME, FULLSYSNAME,
X  		MYDOMAIN);
X  	else
X  #endif /* !HIDDENNET */
X
X--- 783,789 -----
X  	unlock();
X  #ifdef HIDDENNET
X  	if (strcmp(LOCALSYSNAME, FULLSYSNAME))
X! 		(void) sprintf(hp->ident, "<%ld@%s.%s>", seqn, LOCALSYSNAME,
X  		MYDOMAIN);
X  	else
X  #endif /* !HIDDENNET */
X***************
X*** 787,793
X  		MYDOMAIN);
X  	else
X  #endif /* !HIDDENNET */
X! 	(void) sprintf(hp->ident, "<%ld@%s%s>", seqn, FULLSYSNAME, MYDOMAIN);
X  }
X  
X  /*
X
X--- 787,793 -----
X  		MYDOMAIN);
X  	else
X  #endif /* !HIDDENNET */
X! 	(void) sprintf(hp->ident, "<%ld@%s>", seqn, MYDOMAIN);
X  }
X  
X  /*
X***************
X*** 1007,1013
X  		fn = fullname(logname);
X  
X  	(void) sprintf(hp->path, "%s", logname);
X! 	(void) sprintf(hp->from, "%s@%s%s (%s)", logname, FULLSYSNAME, MYDOMAIN, fn);
X  }
X  
X  /*
X
X--- 1007,1013 -----
X  		fn = fullname(logname);
X  
X  	(void) sprintf(hp->path, "%s", logname);
X! 	(void) sprintf(hp->from, "%s@%s (%s)", logname, MYDOMAIN, fn);
X  }
X  
X  /*
/
echo 'x - src.inews.c.diff'
sed 's/^X//' > src.inews.c.diff << '/'
X*** inews.c.orig	Wed Feb 25 02:42:25 1987
X--- inews.c	Wed Feb 25 02:46:56 1987
X***************
X*** 356,363
X  					*p1 = '\0';
X  			}
X  			if (!Mflag && !strpbrk(forgedname, "@ (<"))
X! 				(void) sprintf(header.from,"%s@%s%s",
X! 					forgedname, FULLSYSNAME, MYDOMAIN);
X  			else
X  				(void) strncpy(header.from, forgedname, BUFLEN);
X  
X
X--- 356,363 -----
X  					*p1 = '\0';
X  			}
X  			if (!Mflag && !strpbrk(forgedname, "@ (<"))
X! 				(void) sprintf(header.from,"%s@%s",
X! 					forgedname, MYDOMAIN);
X  			else
X  				(void) strncpy(header.from, forgedname, BUFLEN);
X  
X***************
X*** 361,368
X  			else
X  				(void) strncpy(header.from, forgedname, BUFLEN);
X  
X! 			(void) sprintf(header.sender, "%s@%s%s",
X! 				username, FULLSYSNAME, MYDOMAIN);
X  		} else {
X  			gensender(&header, username);
X  		}
X
X--- 361,368 -----
X  			else
X  				(void) strncpy(header.from, forgedname, BUFLEN);
X  
X! 			(void) sprintf(header.sender, "%s@%s",
X! 				username, MYDOMAIN);
X  		} else {
X  			gensender(&header, username);
X  		}
X***************
X*** 637,644
X  		*cp = '\0';
X  
X  	if (header.approved[0] == '\0')
X! 		(void) sprintf(header.approved, "%s@%s%s",
X! 				username, FULLSYSNAME, MYDOMAIN);
X  	(void) sprintf(bfr, "%s/inews -n %s.ctl -c newgroup %s -d %s -a \"%s\"",
X  		LIB, header.nbuf, header.ctlmsg, header.distribution,
X  		header.approved);
X
X--- 637,644 -----
X  		*cp = '\0';
X  
X  	if (header.approved[0] == '\0')
X! 		(void) sprintf(header.approved, "%s@%s",
X! 				username, MYDOMAIN);
X  	(void) sprintf(bfr, "%s/inews -n %s.ctl -c newgroup %s -d %s -a \"%s\"",
X  		LIB, header.nbuf, header.ctlmsg, header.distribution,
X  		header.approved);
/
echo 'Part 01 of pack.out complete.'
exit
----------------------------------- Cut Here ----------------------------------
-- 
EMAIL:	stephen@comp.lancs.ac.uk	| Post: University of Lancaster,
UUCP:	...!mcvax!ukc!dcl-cs!stephen	|	Department of Computing,
Phone:	+44 524 65201 Ext. 4120		|	Bailrigg, Lancaster, UK.
Project:Alvey ECLIPSE Distribution	|	LA1 4YR