Relay-Version: version B 2.10 5/3/83; site utzoo.UUCP
Path: utzoo!utgpu!water!watnot!watmath!clyde!rutgers!dayton!ems!mark
From: mark@ems.UUCP
Newsgroups: news.software.b
Subject: Problem with News 2.11.6 and fix
Message-ID: <199@ems.UUCP>
Date: Fri, 27-Mar-87 01:41:02 EST
Article-I.D.: ems.199
Posted: Fri Mar 27 01:41:02 1987
Date-Received: Sat, 28-Mar-87 11:11:31 EST
Organization: EMS/McGraw-Hill, Eden Prairie, MN
Lines: 45
Keywords: Hmmmm...

I updated to version 2.11.6 of the news software (from 2.11.5) tonight.  After
having successfully patched and compiled the software I ran a test to a local 
test group here.  News came back and said that news had spooled my article for 
later processing as expected.  I then ran rnews -U to unspool the files 
immediately and got the following error:

	inews: rnews failed, status 256.  Batch saved in <filename>.

I went and looked at the source and found if rnews -U is called it spawns off 
a child rnews -S -p for each batch in the SPOOL/.rnews directory.  The parent 
dutifully waits until the child returns and then checks the return status of 
the child process.  Status 256 indicates that the child terminated by an exit 
with an exit code of 1.

Looking up a couple lines of code, the code to fork off the child process
reads:

			if ((pid=vfork()) == -1)
				xerror("Can't fork: %s", errmsg(errno));
			if (pid == 0) {
#ifdef IHCC
				char bufr[BUFSIZ];
				sprintf(bufr, "%s/%s", logdir(HOME), RNEWS);
				execl(bufr, "rnews", "-S", "-p", dir->d_name,
					(char *) NULL);
#else /* !IHCC */
				execl(RNEWS, "rnews", "-S", "-p", dir->d_name,
					(char *) NULL);
#endif /* !IHCC */
				_exit(1);
				^^^^^^^^^
			}
		
This means that the child will _ALWAYS_ exit with a code of 1, and the 
parent will _ALWAYS_ abort with an error of 256.  Obviously the fix is to 
modify the _exit(1) to an _exit(0).

The question I have is:  am I the only one with this problem?


-- 
Mark H. Colburn    UUCP: ihnp4!meccts!ems!mark, mark@ems.uucp      
EMS/McGraw-Hill    AT&T: (612) 829-8200
                      Copyright (C) 1987 Mark H. Colburn 
          Redistribution allowed only if recipients may redistribute.