Relay-Version: version B 2.10 5/3/83; site utzoo.UUCP Path: utzoo!utgpu!bnr-vpa!bruce From: bruce@bnr-vpa.UUCP Newsgroups: news.software.b Subject: Re: Patch #6 for news 2.11 source Message-ID: <142@bnr-vpa.UUCP> Date: Tue, 31-Mar-87 16:14:25 EST Article-I.D.: bnr-vpa.142 Posted: Tue Mar 31 16:14:25 1987 Date-Received: Wed, 1-Apr-87 06:29:38 EST References: <43222@beno.seismo.CSS.GOV> <536@ncrpcd.UUCP> Organization: Bell-Northern Research, Ottawa, Ontario Lines: 27 Summary: Another bug (when LOCKF defined and F_RDLCK is not) In article <536@ncrpcd.UUCP>, tb@ncrpcd.UUCP (Tom Bertelson) writes: > I encountered a typo while compiling inews.c with DBM undefined... > That bit me too. For systems that define LOCKF, there is another potential problem - a line in inews.c: struct flock news_lock; where the struct flock is undefined. I presume that this is defined on systems where F_RDLCK is also defined (not mine - an HP9000s500 running HP-UX - a SVr2 variant), since the only place news_lock is subsequently used is between # ifdef F_RDLCK # endif /* !F_RDLCK */ statements. The obvious fix is to also #ifdef the offending line; thus: # ifdef F_RDLCK struct flock news_lock; # endif /* !F_RDLCK */ I do not claim to be knowledgeable about the news software; treat my submission accordingly. regards, -- Bruce Townsend (bnr-vpa!bruce) Phone: (613) 726-3008 Bell-Northern Research Usenet: {utzoo, utcs}!bnr-vpa!bruce P.O. Box 3511, Station C, Ottawa, Ontario, Canada, K1Y 4H7