Relay-Version: version B 2.10 5/3/83; site utzoo.UUCP Path: utzoo!mnetor!seismo!rutgers!sri-spam!mordor!styx!ptsfa!ihnp4!drutx!tsf From: tsf@drutx.ATT.COM (FisherTS) Newsgroups: rec.games.empire,comp.sources.d Subject: Re: Another Bug Fix to Empire 1.1 Message-ID: <3685@drutx.ATT.COM> Date: Fri, 24-Apr-87 15:51:40 EST Article-I.D.: drutx.3685 Posted: Fri Apr 24 15:51:40 1987 Date-Received: Sun, 26-Apr-87 00:12:05 EST Distribution: comp Organization: AT&T, Denver, CO Lines: 23 Keywords: fix bug carefully Xref: mnetor rec.games.empire:86 comp.sources.d:631 Be careful with those fixes to the rolling civilians bug. As Jay pointed out, the first attempt causes a recursion problem if two sectors deliver civvies to each other. This second attempt will follow a civilian delivery chain into an area where a hurricane could be lurking or plague might be starting. And if enough sectors are involved, I think the stack could be blown on some machines. I fixed this problem in Version 1.2 after experimenting with several ideas. It might not be perfect, but it doesn't seem to be wildly recursive or have unexpected side effects. I think the Version 1.2 fix involves adding a define to emp.h and a few lines in update.c. If you have 1.1, use the 1.1-1.2 conversion script to get the fix. In general, don't mess with update.c. It's fragile, and more than once I've been surprised by unexpected side effects. If you must change these sensitive routines, please rename your version to something other than 1.1 or 1.2 so I don't get it confused with something I sent out. Thanks. Tom Fisher ihnp4!drutx!tsf