Relay-Version: version B 2.10 5/3/83; site utzoo.UUCP
Path: utzoo!mnetor!seismo!mcvax!botter!ark!smagt
From: smagt@cs.vu.nl (Smagt v der PPP)
Newsgroups: comp.os.minix
Subject: MINIX printer driver
Message-ID: <1004@ark.cs.vu.nl>
Date: Thu, 7-May-87 08:37:00 EDT
Article-I.D.: ark.1004
Posted: Thu May  7 08:37:00 1987
Date-Received: Sat, 9-May-87 09:44:12 EDT
Organization: V.U. Informatica, Amsterdam, the Netherlands
Lines: 46
Keywords: printer.c


Again I post patches to the MINIX printer driver. I did this before,
but those patches did not do well. Some printers, when being addressed
using the printer driver with my previous patches, stopped after
printing a few lines for returning an incorrect status (according to
the driver). All the driver could do then was display "Printer error".

The patches in kernel/printer.c are very simple, again:

change
	#define NORMAL_STATUS   0xDF	/* ... */
to
	#define NORMAL_STATUS	0x90	/* ... */

change
	#define BUSY_STATUS	0x5F	/* ... */
to
	#define BUSY_STATUS	0x10	/* ... */

and add the definition
#define STATUS_MASK	0xB0	/* mask to filter out status bits */

Next, all tests 
	if (value == NORMAL_STATUS)
and
	if (value == BUSY_STATUS)
must be changed to
	if (value&STATUS_MASK == NORMAL_STATUS)
or
	if (value&STATUS_MASK == BUSY_STATUS)
respectively (for a total of five tests).

For those of you who installed my previous patches, the 'original'
tests in your file printer.c look like
	if ((value|LOW_FOUR) == NORMAL_STATUS)
and
	if ((value|LOW_FOUR) == BUSY_STATUS)


I do trust your printer will work now.

					P. van der Smagt
					VU Informatica
					Amsterdam
					The Netherlands
					(send mail to smagt@cs.vu.nl)