Relay-Version: version B 2.10 5/3/83; site utzoo.UUCP
Path: utzoo!utgpu!water!watmath!clyde!rutgers!husc6!necntc!necis!encore!loverso
From: loverso@encore.UUCP
Newsgroups: comp.bugs.4bsd
Subject: 4.3 netstat doesn't show all ICMP packet counts
Message-ID: <1887@encore.UUCP>
Date: Tue, 1-Sep-87 17:37:09 EDT
Article-I.D.: encore.1887
Posted: Tue Sep  1 17:37:09 1987
Date-Received: Thu, 3-Sep-87 01:36:45 EDT
Organization: Encore Computer Corp., Marlboro, MA
Lines: 45
Keywords: 4.3 netstat ICMP

Index: 	ucb/netstat 4.3BSD Fix

Description:
	"netstat -s" doesn't list counts of ICMP address mask request
	and address mask reply's sent/recieved.  Its simply a matter
	of comparing against the wrong upper boundary.

Repeat-By:
	port the code to an Annex terminal server.

Fix:
	Apply this diff:

*** inet.c_orig	Tue Sep  1 17:30:56 1987
--- inet.c	Tue Sep  1 17:31:49 1987
***************
*** 249,253 ****
  	printf("\t%d error%s not generated 'cuz old message was icmp\n",
  		icmpstat.icps_oldicmp, plural(icmpstat.icps_oldicmp));
! 	for (first = 1, i = 0; i < ICMP_IREQREPLY + 1; i++)
  		if (icmpstat.icps_outhist[i] != 0) {
  			if (first) {
--- 249,253 ----
  	printf("\t%d error%s not generated 'cuz old message was icmp\n",
  		icmpstat.icps_oldicmp, plural(icmpstat.icps_oldicmp));
! 	for (first = 1, i = 0; i < ICMP_MAXTYPE + 1; i++)
  		if (icmpstat.icps_outhist[i] != 0) {
  			if (first) {
***************
*** 266,270 ****
  	printf("\t%d message%s with bad length\n",
  		icmpstat.icps_badlen, plural(icmpstat.icps_badlen));
! 	for (first = 1, i = 0; i < ICMP_IREQREPLY + 1; i++)
  		if (icmpstat.icps_inhist[i] != 0) {
  			if (first) {
--- 266,270 ----
  	printf("\t%d message%s with bad length\n",
  		icmpstat.icps_badlen, plural(icmpstat.icps_badlen));
! 	for (first = 1, i = 0; i < ICMP_MAXTYPE + 1; i++)
  		if (icmpstat.icps_inhist[i] != 0) {
  			if (first) {

--
John Robert LoVerso, Encore Computer Corp
encore!loverso, loverso@multimax.arpa